ttygroup/boartty
Code Issues Proposed changes

Colorize values in review dialog

Browse Source 
Use the same light/dark red/green used for votes.

Change-Id: Idc94c7c4aa4f0b61fb8e75a605c273ef9d949a6f
This commit is contained in:
James E. Blair 2015-01-13 16:29:19 +13:00
parent 154ddc8766
commit 08fe604a2b
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
gertty/view/change.py
View File

@ -114,6 +114,12 @@ class ReviewDialog(urwid.WidgetWrap):
for label in change.labels:
d = descriptions.setdefault(label.category, {})
d[label.value] = label.description
vmin = d.setdefault('min', label.value)
if label.value < vmin:
d['min'] = label.value
vmax = d.setdefault('max', label.value)
if label.value > vmax:
d['max'] = label.value
for label in change.permitted_labels:
if label.category not in categories:
categories.append(label.category)
@ -141,6 +147,16 @@ class ReviewDialog(urwid.WidgetWrap):
strvalue += ' ' + descriptions[category][value]
b = urwid.RadioButton(group, strvalue, state=(value == current))
b._value = value
if value > 0:
if value == descriptions[category]['max']:
b = urwid.AttrMap(b, 'max-label')
else:
b = urwid.AttrMap(b, 'positive-label')
elif value < 0:
if value == descriptions[category]['min']:
b = urwid.AttrMap(b, 'min-label')
else:
b = urwid.AttrMap(b, 'negative-label')
rows.append(b)
rows.append(urwid.Divider())
m = revision.getPendingMessage()