From 43de3e6910d482d890e95c23f8d3561d680775d0 Mon Sep 17 00:00:00 2001 From: Michel Thebeau Date: Mon, 14 Aug 2023 15:20:27 -0400 Subject: [PATCH] libvirt: fix readconfig.sh usage and permissions readconfig.sh intends to export variables to the current shell, and should be sourced using the 'source' command. It is ineffective when run as a sub-process. Fix the file permission, since the script should be sourced rather than executed. Test Plan: PASS: regression of default and madcloud examples PASS: documented usage is effective Story: 2010816 Task: 48614 Change-Id: I7e35ccf253e27b8209f8bf17dca065c58b016e14 Signed-off-by: Michel Thebeau --- libvirt/README.rst | 2 +- libvirt/readconfig.sh | 0 2 files changed, 1 insertion(+), 1 deletion(-) mode change 100755 => 100644 libvirt/readconfig.sh diff --git a/libvirt/README.rst b/libvirt/README.rst index 498202a..2564cf3 100644 --- a/libvirt/README.rst +++ b/libvirt/README.rst @@ -28,7 +28,7 @@ an interactive shell that configures everything. Here's an example:: export EXTERNAL_NETWORK=172.30.20.0/24 export EXTERNAL_IP=172.30.20.1/24 -Using ``./readconfig.sh madcloud.yaml`` also sets the madcloud +Using ``source ./readconfig.sh madcloud.yaml`` also sets the madcloud environment variables. Use ``default.yaml`` or ``madcloud.yaml`` as templates to make custom configurations. diff --git a/libvirt/readconfig.sh b/libvirt/readconfig.sh old mode 100755 new mode 100644