stackforge/rubick
Code Issues Proposed changes

Added caching of parsed config values

Browse Source
This commit is contained in:
Maxim Kulkin 2013-09-19 15:10:54 +04:00
parent 2fff19947c
commit 52a10713d9
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ostack_validator/config_formats/ini.py
View File

@ -100,7 +100,7 @@ class IniConfigParser:
mark(line_number, m.start(3)), mark(line_number, m.start(3)),
mark(line_number, m.end(3)), mark(line_number, m.end(3)),
value, value,
quotechar quotechar=quotechar
) )
else: else:
errors.append(ParseError('Syntax error', mark(line_number))) errors.append(ParseError('Syntax error', mark(line_number)))

1
ostack_validator/inspection.py
View File

@ -58,6 +58,7 @@ class MainConfigValidationInspection(Inspection):
else: else:
value = type_validation_result value = type_validation_result
parameter.value.value = value
if value == parameter_schema.default: if value == parameter_schema.default:
results.append(MarkedIssue(Issue.INFO, 'Parameter "%s" value equals default' % parameter.name.text, parameter.start_mark)) results.append(MarkedIssue(Issue.INFO, 'Parameter "%s" value equals default' % parameter.name.text, parameter.start_mark))

4
ostack_validator/model.py
View File

@ -108,8 +108,8 @@ class ConfigParameter(Element):
class ConfigParameterName(TextElement): pass class ConfigParameterName(TextElement): pass
class ConfigParameterValue(TextElement): class ConfigParameterValue(TextElement):
def __init__(self, start_mark, end_mark, text, quotechar=None): def __init__(self, start_mark, end_mark, text, value=None, quotechar=None):
super(ConfigParameterValue, self).__init__(start_mark, end_mark, text) super(ConfigParameterValue, self).__init__(start_mark, end_mark, text)
self.value = value
self.quotechar = quotechar self.quotechar = quotechar