stackforge/puppet-openstack-cloud
Code Issues Proposed changes

dashboard: Deprecated fqdn parameter to horizon

Browse Source 
Specifying fqdn to horizon was the old way to specify ALLOWED_HOSTS entries.
It has been deprecated, and now one should rely on $allowed_hosts.

Note: There is no deprecation warning, since there was no way to specify
the fqdn value, it was bound to `$api_eth`. This change is transparent
to the user
This commit is contained in:
Yanis Guenane 2014-10-07 20:53:19 -04:00
parent e2899f5796
commit da033cf77b
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/dashboard.pp
View File

@ -115,10 +115,6 @@ class cloud::dashboard(
class { 'horizon':
secret_key => $secret_key,
can_set_mount_point => 'False',
# fqdn can can be ambiguous since we use reverse DNS here,
# e.g: 127.0.0.1 instead of a public IP address.
# We force $api_eth to avoid this situation
fqdn => $api_eth,
servername => $servername,
bind_address => $api_eth,
swift => true,

2
spec/classes/cloud_dashboard_spec.rb
View File

@ -43,7 +43,6 @@ describe 'cloud::dashboard' do
:listen_ssl => false,
:secret_key => '/etc/ssl/secret',
:can_set_mount_point => 'False',
:fqdn => '10.0.0.1',
:bind_address => '10.0.0.1',
:servername => 'horizon.openstack.org',
:swift => true,
@ -71,7 +70,6 @@ describe 'cloud::dashboard' do
:listen_ssl => false,
:secret_key => '/etc/ssl/secret',
:can_set_mount_point => 'False',
:fqdn => '10.0.0.1',
:bind_address => '10.0.0.1',
:servername => 'horizon.openstack.org',
:swift => true,