stackforge/puppet-openstack-cloud
Code Issues Proposed changes

keyring permissions: fix PATH

Browse Source 
PATH needs to include:
- /usr/sbin and /usr/bin
- /sbin and /bin

for running grep and groups commands.

Signed-off-by: Emilien Macchi <emilien.macchi@enovance.com>
This commit is contained in:
Emilien Macchi 2014-04-26 15:29:26 +02:00
parent f8de2fb334
commit d894d334ec
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/compute/hypervisor.pp
View File

@ -147,7 +147,7 @@ Host *
ensure_resource ('exec','add-nova-to-group', { ensure_resource ('exec','add-nova-to-group', {
'command' => 'usermod -a -G cephkeyring nova', 'command' => 'usermod -a -G cephkeyring nova',
'path' => ['/usr/sbin', '/sbin'], 'path' => ['/usr/sbin', '/usr/bin', '/bin', '/sbin'],
'unless' => 'groups nova | grep cephkeyring' 'unless' => 'groups nova | grep cephkeyring'
}) })

2
manifests/volume/backend/rbd.pp
View File

@ -82,7 +82,7 @@ define cloud::volume::backend::rbd (
ensure_resource ('exec','add-cinder-to-group', { ensure_resource ('exec','add-cinder-to-group', {
'command' => 'usermod -a -G cephkeyring cinder', 'command' => 'usermod -a -G cephkeyring cinder',
'path' => ['/usr/sbin', '/sbin'], 'path' => ['/usr/sbin', '/usr/bin', '/bin', '/sbin'],
'unless' => 'groups cinder | grep cephkeyring' 'unless' => 'groups cinder | grep cephkeyring'
}) })

2
spec/classes/cloud_compute_hypervisor_spec.rb
View File

@ -240,7 +240,7 @@ describe 'cloud::compute::hypervisor' do
should contain_exec('add-nova-to-group').with( should contain_exec('add-nova-to-group').with(
:command => 'usermod -a -G cephkeyring nova', :command => 'usermod -a -G cephkeyring nova',
:unless => 'groups nova | grep cephkeyring', :unless => 'groups nova | grep cephkeyring',
:path => ['/usr/sbin', '/sbin'] :path => ['/usr/sbin', '/usr/bin', '/bin', '/sbin']
) )
end end

2
spec/classes/cloud_volume_storage_spec.rb
View File

@ -111,7 +111,7 @@ describe 'cloud::volume::storage' do
should contain_group('cephkeyring').with(:ensure => 'present') should contain_group('cephkeyring').with(:ensure => 'present')
should contain_exec('add-cinder-to-group').with( should contain_exec('add-cinder-to-group').with(
:command => 'usermod -a -G cephkeyring cinder', :command => 'usermod -a -G cephkeyring cinder',
:path => ['/usr/sbin', '/sbin'], :path => ['/usr/sbin', '/usr/bin', '/bin', '/sbin'],
:unless => 'groups cinder | grep cephkeyring' :unless => 'groups cinder | grep cephkeyring'
) )
end end