stackforge/puppet-openstack-cloud
Code Issues Proposed changes

Add unit tests

Browse Source 
Signed-off-by: Emilien Macchi <emilien.macchi@enovance.com>
This commit is contained in:
Emilien Macchi 2014-02-25 16:31:01 +01:00
parent 83cee98ded
commit 99b539988c
13 changed files with 28 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
spec/classes/cloud_compute_controller_spec.rb
View File

@ -66,7 +66,8 @@ describe 'cloud::compute::controller' do
:rabbit_virtual_host => '/',
:memcached_servers => ['10.0.0.1','10.0.0.2'],
:database_connection => 'mysql://nova:secrete@10.0.0.1/nova?charset=utf8',
:glance_api_servers => 'http://10.0.0.1:9292'
:glance_api_servers => 'http://10.0.0.1:9292',
:log_dir => false
)
should contain_nova_config('DEFAULT/resume_guests_state_on_host_boot').with('value' => true)
should contain_nova_config('DEFAULT/default_availability_zone').with('value' => 'MyZone')

3
spec/classes/cloud_compute_hypervisor_spec.rb
View File

@ -92,7 +92,8 @@ describe 'cloud::compute::hypervisor' do
:rabbit_virtual_host => '/',
:memcached_servers => ['10.0.0.1','10.0.0.2'],
:database_connection => 'mysql://nova:secrete@10.0.0.1/nova?charset=utf8',
:glance_api_servers => 'http://10.0.0.1:9292'
:glance_api_servers => 'http://10.0.0.1:9292',
:log_dir => false
)
should contain_nova_config('DEFAULT/resume_guests_state_on_host_boot').with('value' => true)
should contain_nova_config('DEFAULT/default_availability_zone').with('value' => 'MyZone')

3
spec/classes/cloud_identity_spec.rb
View File

@ -110,7 +110,8 @@ describe 'cloud::identity' do
:bind_host => '10.0.0.1',
:public_port => '5000',
:admin_port => '35357',
:token_expiration => '3600'
:token_expiration => '3600',
:log_dir => false
)
should contain_keystone_config('ec2/driver').with('value' => 'keystone.contrib.ec2.backends.sql.Ec2')
end

6
spec/classes/cloud_image_spec.rb
View File

@ -58,7 +58,7 @@ describe 'cloud::image' do
:log_facility => 'LOG_LOCAL0',
:bind_host => '10.0.0.1',
:bind_port => '9292',
:use_syslog => true
:use_syslog => true,
)
end
@ -74,7 +74,9 @@ describe 'cloud::image' do
:log_facility => 'LOG_LOCAL0',
:bind_host => '10.0.0.1',
:bind_port => '9191',
:use_syslog => true
:use_syslog => true,
:log_dir => false,
:log_file => false,
)
end

3
spec/classes/cloud_network_controller_spec.rb
View File

@ -59,7 +59,8 @@ describe 'cloud::network::controller' do
:rabbit_virtual_host => '/',
:bind_host => '10.0.0.1',
:core_plugin => 'neutron.plugins.ml2.plugin.Ml2Plugin',
:service_plugins => ['neutron.services.loadbalancer.plugin.LoadBalancerPlugin','neutron.services.metering.metering_plugin.MeteringPlugin','neutron.services.l3_router.l3_router_plugin.L3RouterPlugin']
:service_plugins => ['neutron.services.loadbalancer.plugin.LoadBalancerPlugin','neutron.services.metering.metering_plugin.MeteringPlugin','neutron.services.l3_router.l3_router_plugin.L3RouterPlugin'],
:log_dir => false
)
should contain_class('neutron::agents::ovs').with(

3
spec/classes/cloud_network_dhcp_spec.rb
View File

@ -54,7 +54,8 @@ describe 'cloud::network::dhcp' do
:rabbit_virtual_host => '/',
:bind_host => '10.0.0.1',
:core_plugin => 'neutron.plugins.ml2.plugin.Ml2Plugin',
:service_plugins => ['neutron.services.loadbalancer.plugin.LoadBalancerPlugin','neutron.services.metering.metering_plugin.MeteringPlugin','neutron.services.l3_router.l3_router_plugin.L3RouterPlugin']
:service_plugins => ['neutron.services.loadbalancer.plugin.LoadBalancerPlugin','neutron.services.metering.metering_plugin.MeteringPlugin','neutron.services.l3_router.l3_router_plugin.L3RouterPlugin'],
:log_dir => false
)
should contain_class('neutron::agents::ovs').with(

3
spec/classes/cloud_network_l3_spec.rb
View File

@ -54,7 +54,8 @@ describe 'cloud::network::l3' do
:rabbit_virtual_host => '/',
:bind_host => '10.0.0.1',
:core_plugin => 'neutron.plugins.ml2.plugin.Ml2Plugin',
:service_plugins => ['neutron.services.loadbalancer.plugin.LoadBalancerPlugin','neutron.services.metering.metering_plugin.MeteringPlugin','neutron.services.l3_router.l3_router_plugin.L3RouterPlugin']
:service_plugins => ['neutron.services.loadbalancer.plugin.LoadBalancerPlugin','neutron.services.metering.metering_plugin.MeteringPlugin','neutron.services.l3_router.l3_router_plugin.L3RouterPlugin'],
:log_dir => false
)
should contain_class('neutron::agents::ovs').with(

3
spec/classes/cloud_network_lbaas_spec.rb
View File

@ -53,7 +53,8 @@ describe 'cloud::network::lbaas' do
:rabbit_virtual_host => '/',
:bind_host => '10.0.0.1',
:core_plugin => 'neutron.plugins.ml2.plugin.Ml2Plugin',
:service_plugins => ['neutron.services.loadbalancer.plugin.LoadBalancerPlugin','neutron.services.metering.metering_plugin.MeteringPlugin','neutron.services.l3_router.l3_router_plugin.L3RouterPlugin']
:service_plugins => ['neutron.services.loadbalancer.plugin.LoadBalancerPlugin','neutron.services.metering.metering_plugin.MeteringPlugin','neutron.services.l3_router.l3_router_plugin.L3RouterPlugin'],
:log_dir => false
)
should contain_class('neutron::agents::ovs').with(

3
spec/classes/cloud_network_vpn_spec.rb
View File

@ -49,7 +49,8 @@ describe 'cloud::network::vpn' do
:rabbit_virtual_host => '/',
:bind_host => '10.0.0.1',
:core_plugin => 'neutron.plugins.ml2.plugin.Ml2Plugin',
:service_plugins => ['neutron.services.loadbalancer.plugin.LoadBalancerPlugin','neutron.services.metering.metering_plugin.MeteringPlugin','neutron.services.l3_router.l3_router_plugin.L3RouterPlugin']
:service_plugins => ['neutron.services.loadbalancer.plugin.LoadBalancerPlugin','neutron.services.metering.metering_plugin.MeteringPlugin','neutron.services.l3_router.l3_router_plugin.L3RouterPlugin'],
:log_dir => false
)
should contain_class('neutron::agents::ovs').with(

3
spec/classes/cloud_orchestration_api_spec.rb
View File

@ -65,7 +65,8 @@ describe 'cloud::orchestration::api' do
:keystone_protocol => 'http',
:keystone_password => 'secrete',
:auth_uri => 'http://10.0.0.1:5000/v2.0',
:sql_connection => 'mysql://heat:secrete@10.0.0.1/heat'
:sql_connection => 'mysql://heat:secrete@10.0.0.1/heat',
:log_dir => false
)
end

3
spec/classes/cloud_orchestration_engine_spec.rb
View File

@ -68,7 +68,8 @@ describe 'cloud::orchestration::engine' do
:keystone_protocol => 'http',
:keystone_password => 'secrete',
:auth_uri => 'http://10.0.0.1:5000/v2.0',
:sql_connection => 'mysql://heat:secrete@10.0.0.1/heat'
:sql_connection => 'mysql://heat:secrete@10.0.0.1/heat',
:log_dir => false
)
end

3
spec/classes/cloud_volume_controller_spec.rb
View File

@ -58,7 +58,8 @@ describe 'cloud::volume::controller' do
:rabbit_password => 'secrete',
:rabbit_virtual_host => '/',
:log_facility => 'LOG_LOCAL0',
:use_syslog => true
:use_syslog => true,
:log_dir => false
)
should contain_class('cinder::ceilometer')
end

3
spec/classes/cloud_volume_storage_spec.rb
View File

@ -53,7 +53,8 @@ describe 'cloud::volume::storage' do
:rabbit_password => 'secrete',
:rabbit_virtual_host => '/',
:log_facility => 'LOG_LOCAL0',
:use_syslog => true
:use_syslog => true,
:log_dir => false
)
should contain_cinder_config('DEFAULT/notification_driver').with('value' => 'cinder.openstack.common.notifier.rpc_notifier')