stackforge/puppet-openstack-cloud
Code Issues Proposed changes

add tests for default value for nova-scheduler filters

Browse Source
This commit is contained in:
Nicolas Hicher 2014-08-12 12:06:06 -04:00
parent a89621b839
commit 95caf7e19b
1 changed files with 38 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
spec/classes/cloud_compute_scheduler_spec.rb
View File

@ -43,10 +43,6 @@ describe 'cloud::compute::scheduler' do
log_facility => 'LOG_LOCAL0' }"
end
let :params do
{ :scheduler_default_filters => ['RamFilter', 'ComputeFilter'] }
end
it 'configure nova common' do
should contain_class('nova').with(
:verbose => true,
@ -90,6 +86,13 @@ describe 'cloud::compute::scheduler' do
should contain_class('nova::scheduler').with(:enabled => true)
end
end
shared_examples_for 'openstack compute scheduler with nova-scheduler filters' do
let :params do
{ :scheduler_default_filters => ['RamFilter', 'ComputeFilter'] }
end
it 'configure nova-scheduler filters' do
should contain_class('nova::scheduler::filter').with(
:scheduler_default_filters => ['RamFilter', 'ComputeFilter']
@ -98,7 +101,16 @@ describe 'cloud::compute::scheduler' do
'value' => "RamFilter,ComputeFilter"
)
end
end
shared_examples_for 'openstack compute scheduler without nova-scheduler filters' do
it 'not configure nova-scheduler filters' do
should contain_class('nova::scheduler::filter').with(
:scheduler_default_filters => false
)
should_not contain_nova_config('scheduler_default_filters')
end
end
context 'on Debian platforms' do
@ -107,6 +119,18 @@ describe 'cloud::compute::scheduler' do
end
it_configures 'openstack compute scheduler'
it_configures 'openstack compute scheduler without nova-scheduler filters'
end
context 'on Debian platforms with nova-scheduler filters' do
let :facts do
{ :osfamily => 'Debian' }
end
it_configures 'openstack compute scheduler'
it_configures 'openstack compute scheduler with nova-scheduler filters'
end
context 'on RedHat platforms' do
@ -114,6 +138,16 @@ describe 'cloud::compute::scheduler' do
{ :osfamily => 'RedHat' }
end
it_configures 'openstack compute scheduler'
it_configures 'openstack compute scheduler without nova-scheduler filters'
end
context 'on RedHat platforms with nova-scheduler filters' do
let :facts do
{ :osfamily => 'RedHat' }
end
it_configures 'openstack compute scheduler'
it_configures 'openstack compute scheduler with nova-scheduler filters'
end
end