From da033cf77beab6939254657148bd265d724ae348 Mon Sep 17 00:00:00 2001 From: Yanis Guenane Date: Tue, 7 Oct 2014 20:53:19 -0400 Subject: [PATCH] dashboard: Deprecated fqdn parameter to horizon Specifying fqdn to horizon was the old way to specify ALLOWED_HOSTS entries. It has been deprecated, and now one should rely on $allowed_hosts. Note: There is no deprecation warning, since there was no way to specify the fqdn value, it was bound to `$api_eth`. This change is transparent to the user --- manifests/dashboard.pp | 4 ---- spec/classes/cloud_dashboard_spec.rb | 2 -- 2 files changed, 6 deletions(-) diff --git a/manifests/dashboard.pp b/manifests/dashboard.pp index 19b2b28c..672eab48 100644 --- a/manifests/dashboard.pp +++ b/manifests/dashboard.pp @@ -115,10 +115,6 @@ class cloud::dashboard( class { 'horizon': secret_key => $secret_key, can_set_mount_point => 'False', - # fqdn can can be ambiguous since we use reverse DNS here, - # e.g: 127.0.0.1 instead of a public IP address. - # We force $api_eth to avoid this situation - fqdn => $api_eth, servername => $servername, bind_address => $api_eth, swift => true, diff --git a/spec/classes/cloud_dashboard_spec.rb b/spec/classes/cloud_dashboard_spec.rb index 4460b94b..42b96a78 100644 --- a/spec/classes/cloud_dashboard_spec.rb +++ b/spec/classes/cloud_dashboard_spec.rb @@ -43,7 +43,6 @@ describe 'cloud::dashboard' do :listen_ssl => false, :secret_key => '/etc/ssl/secret', :can_set_mount_point => 'False', - :fqdn => '10.0.0.1', :bind_address => '10.0.0.1', :servername => 'horizon.openstack.org', :swift => true, @@ -71,7 +70,6 @@ describe 'cloud::dashboard' do :listen_ssl => false, :secret_key => '/etc/ssl/secret', :can_set_mount_point => 'False', - :fqdn => '10.0.0.1', :bind_address => '10.0.0.1', :servername => 'horizon.openstack.org', :swift => true,