Merge pull request #328 from enovance/bug/326/sbadia

Fix various lint and errors

Rakefile

@@ -8,7 +8,7 @@ PuppetLint.configuration.send('disable_class_parameter_defaults')
 # For stonith-enabled (it's a string not a bool)
 PuppetLint.configuration.send('disable_quoted_booleans')
 # Ignore all upstream modules
-PuppetLint.configuration.ignore_paths = ['spec/fixtures/modules/**/*.pp']
+PuppetLint.configuration.ignore_paths = ['spec/fixtures/modules/**/*.pp','examples/*.pp']
 
 task(:default).clear
 task :default => [:spec_prep, :spec_standalone, :lint]

examples/params.pp

@@ -84,7 +84,7 @@ class os_params {
     "${galera_master_name}" => $mgmt_internal_ips[0],
     "${mgmt_names[1]}"      => $mgmt_internal_ips[1],
     "${mgmt_names[2]}"      => $mgmt_internal_ips[2],
-   }
+  }
 
   $ceph_version       = 'cuttlefish'
 

manifests/identity.pp

@@ -456,8 +456,6 @@ class cloud::identity (
     region           => $region,
   }
 
-  keystone_config { 'ssl/enable': ensure => absent }
-
   # TODO(EmilienM) Disable WSGI - bug #98
   #include 'apache'
   # class {'keystone::wsgi::apache':

spec/classes/cloud_compute_hypervisor_spec.rb

@@ -261,7 +261,9 @@ describe 'cloud::compute::hypervisor' do
 
   context 'on Debian platforms' do
     let :facts do
-      { :osfamily => 'Debian' }
+      { :osfamily       => 'Debian',
+        :concat_basedir => '/var/lib/puppet/concat'
+      }
     end
 
     it_configures 'openstack compute hypervisor'
@@ -269,7 +271,9 @@ describe 'cloud::compute::hypervisor' do
 
   context 'on RedHat platforms' do
     let :facts do
-      { :osfamily => 'RedHat' }
+      { :osfamily => 'RedHat',
+        :concat_basedir => '/var/lib/puppet/concat'
+      }
     end
 
     it_configures 'openstack compute hypervisor'