stackforge/puppet-openstack-cloud
Code Issues Proposed changes

Remove Glance cache

Browse Source 
Our default backend is RBD, using the 'keystone+cachemanagement' is
extremely dangerous since it will result in images getting cached in the
controllers under /var/lib/glance/image-cache/ and will potentially lead to
a full system sooner or later. Moreover since we use RBD CoW clone there
is no point to cache anything. Everytime a virtual machine is booted
often, this image will go into the cache. Think about Windows 50GB big
images, now think about 10 of them :D.

Going further if we have to use another backend I won't recommend using
it. I only Swift as a suitable backend for this, but regarding some
recent effort on the Nova side (image direct url) to get the image
directly from the storage entity I don't think it's useful to have any
images cached anyways.

Signed-off-by: Sébastien Han <sebastien.han@enovance.com>
This commit is contained in:
Sébastien Han 2014-10-09 22:25:38 +02:00
parent 52074c5dd5
commit 34093846a3
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
manifests/image/api.pp
View File

@ -83,6 +83,11 @@
# Example: 'nfsvers=3,noacl' # Example: 'nfsvers=3,noacl'
# Defaults to 'defaults' # Defaults to 'defaults'
# #
# [*pipeline*]
# (optional) Partial name of a pipeline in your paste configuration file with the
# service name removed.
# Defaults to 'keystone'.
#
class cloud::image::api( class cloud::image::api(
$glance_db_host = '127.0.0.1', $glance_db_host = '127.0.0.1',
$glance_db_user = 'glance', $glance_db_user = 'glance',
@ -108,6 +113,7 @@ class cloud::image::api(
$filesystem_store_datadir = undef, $filesystem_store_datadir = undef,
$nfs_device = false, $nfs_device = false,
$nfs_options = 'defaults', $nfs_options = 'defaults',
$pipeline = 'keystone',
) { ) {
# Disable twice logging if syslog is enabled # Disable twice logging if syslog is enabled
@ -150,6 +156,7 @@ class cloud::image::api(
bind_host => $api_eth, bind_host => $api_eth,
bind_port => $ks_glance_api_internal_port, bind_port => $ks_glance_api_internal_port,
use_syslog => $use_syslog, use_syslog => $use_syslog,
pipeline => 'keystone',
} }
# TODO(EmilienM) Disabled for now # TODO(EmilienM) Disabled for now

1
spec/classes/cloud_image_api_spec.rb
View File

@ -64,6 +64,7 @@ describe 'cloud::image::api' do
:bind_host => '10.0.0.1', :bind_host => '10.0.0.1',
:bind_port => '9292', :bind_port => '9292',
:use_syslog => true, :use_syslog => true,
:pipeline => 'keystone',
:log_dir => false, :log_dir => false,
:log_file => false :log_file => false
) )