stackforge/openstack-sdk-php
Code Issues Proposed changes

Minor performance improvement to Response.

Browse Source 
Now that we have conditional handling of content(), I added a
tweak to slightly improve CURL performance.
This commit is contained in:
Technosophos 2012-05-31 10:27:39 -05:00
parent efff5a1673
commit 7451d92e29
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/HPCloud/Transport/Response.php
View File

@ -177,11 +177,12 @@ class Response {
} }
} }
else { else {
while (!feof($this->handle)) { // XXX: This works fine with CURL, but will not
$out .= fread($this->handle, 8192); // work with PHP HTTP Stream Wrapper b/c the
// wrapper has a bug that will cause this to
// hang.
$out = stream_get_contents($this->handle);
} }
}
// Should we close or rewind? // Should we close or rewind?
// Cannot rewind PHP HTTP streams. // Cannot rewind PHP HTTP streams.