stackforge/libra
Code Issues Proposed changes

Improve alerting message

Browse Source 
Change-Id: If2c7cc32923427c2e1734d9b8bdd03f9fdb628e9
This commit is contained in:
Andrew Hutchings 2013-04-18 15:33:40 +01:00
parent e568aff26b
commit 5f407569a7
1 changed files with 24 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
libra/statsd/scheduler.py
View File

@ -20,6 +20,10 @@ from libra.statsd.admin_api import AdminAPI
from libra.statsd.gearman import GearJobs from libra.statsd.gearman import GearJobs
class NodeNotFound(Exception):
pass
class Sched(object): class Sched(object):
def __init__(self, logger, args, drivers): def __init__(self, logger, args, drivers):
self.logger = logger self.logger = logger
@ -78,18 +82,34 @@ class Sched(object):
failed_nodes = gearman.send_pings(node_list) failed_nodes = gearman.send_pings(node_list)
failed = len(failed_nodes) failed = len(failed_nodes)
if failed > 0: if failed > 0:
self._send_fails(lb_list, failed_nodes) self._send_fails(lb_list, failed_nodes, lb_list)
else: else:
self.logger.error('No working API server found') self.logger.error('No working API server found')
return (0, 0) return (0, 0)
return pings, failed return pings, failed
def _send_fails(self, failed_nodes): def _send_fails(self, failed_nodes, node_list):
# TODO: add message and more node details
for node in failed_nodes: for node in failed_nodes:
data = self._get_node(node, node_list)
message = (
'Load balancer failed\n'
'ID: {0}\n'
'IP: {0}\n'
'tenant: {0}\n'.format(
data['id'], data['floatingIPAddr'],
data['loadBalancers'][0]['hpcs_tenantid']
)
)
for driver in self.drivers: for driver in self.drivers:
driver.send_alert('Node failed with IP {0}', node) driver.send_alert(message)
def _get_node(self, node, node_list):
for n in node_list:
if n['name'] == node:
return n
raise NodeNotFound
def start_ping_sched(self): def start_ping_sched(self):
self.logger.info('LB ping check timer sleeping for {secs} seconds' self.logger.info('LB ping check timer sleeping for {secs} seconds'