162de47f95
Newly created primitive resources weren't being marked as updated in real runs, because exists? was being run on an old object. Furthermore, the tests didn't catch this because #exists? on any instance of Pacemaker::Resource::Primitive was being mocked to return true. The fix requires re-invoking Pacemaker::CIBObject.from_name after attempting to create the new primitive, so that cib_object.exists? accurately reflects whether the creation succeeded. However, testing this required mocking Mixlib::Shellout#stdout to first return "" and then secondly a definition string for the created resource, and unfortunately this exposed a nasty bug in rspec-mocks: https://github.com/rspec/rspec-mocks/issues/559 So we revamp the mocking of Mixlib::Shellout#stdout to use doubles instead of #expect_any_instance_of.
84 lines
2.6 KiB
Ruby
84 lines
2.6 KiB
Ruby
require 'chef/application'
|
|
require File.expand_path('../spec_helper', File.dirname(__FILE__))
|
|
require File.expand_path('../helpers/cib_object', File.dirname(__FILE__))
|
|
require File.expand_path('../fixtures/colocation_constraint', File.dirname(__FILE__))
|
|
|
|
describe "Chef::Provider::PacemakerColocation" do
|
|
# for use inside examples:
|
|
let(:fixture) { Chef::RSpec::Pacemaker::Config::COLOCATION_CONSTRAINT.dup }
|
|
# for use outside examples (e.g. when invoking shared_examples)
|
|
fixture = Chef::RSpec::Pacemaker::Config::COLOCATION_CONSTRAINT.dup
|
|
|
|
before(:each) do
|
|
runner_opts = {
|
|
:step_into => ['pacemaker_colocation']
|
|
}
|
|
@chef_run = ::ChefSpec::Runner.new(runner_opts)
|
|
@chef_run.converge "pacemaker::default"
|
|
@node = @chef_run.node
|
|
@run_context = @chef_run.run_context
|
|
|
|
@resource = Chef::Resource::PacemakerColocation.new(fixture.name, @run_context)
|
|
@resource.score fixture.score
|
|
@resource.resources fixture.resources.dup
|
|
end
|
|
|
|
let (:provider) { Chef::Provider::PacemakerColocation.new(@resource, @run_context) }
|
|
|
|
def cib_object_class
|
|
Pacemaker::Constraint::Colocation
|
|
end
|
|
|
|
include Chef::RSpec::Pacemaker::CIBObject
|
|
|
|
describe ":create action" do
|
|
def test_modify(expected_cmds)
|
|
yield
|
|
|
|
expect_definitions(fixture.definition_string)
|
|
|
|
provider.run_action :create
|
|
|
|
expected_cmds.each do |cmd|
|
|
expect(@chef_run).to run_execute(cmd)
|
|
end
|
|
expect(@resource).to be_updated
|
|
end
|
|
|
|
it "should modify the constraint if it has a different score" do
|
|
new_score = '100'
|
|
fixture.score = new_score
|
|
expected_configure_cmd_args = [fixture.reconfigure_command]
|
|
test_modify(expected_configure_cmd_args) do
|
|
@resource.score new_score
|
|
end
|
|
end
|
|
|
|
it "should modify the constraint if it has a resource added" do
|
|
new_resource = 'bar:Stopped'
|
|
expected = fixture.dup
|
|
expected.resources = expected.resources.dup + [new_resource]
|
|
expected_configure_cmd_args = [expected.reconfigure_command]
|
|
test_modify(expected_configure_cmd_args) do
|
|
@resource.resources expected.resources
|
|
end
|
|
end
|
|
|
|
it "should modify the constraint if it has a different resource" do
|
|
new_resources = ['bar:Started']
|
|
fixture.resources = new_resources
|
|
expected_configure_cmd_args = [fixture.reconfigure_command]
|
|
test_modify(expected_configure_cmd_args) do
|
|
@resource.resources new_resources
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
describe ":delete action" do
|
|
it_should_behave_like "action on non-existent resource", \
|
|
:delete, "crm configure delete #{fixture.name}", nil
|
|
end
|
|
|
|
end
|