162de47f95
Newly created primitive resources weren't being marked as updated in real runs, because exists? was being run on an old object. Furthermore, the tests didn't catch this because #exists? on any instance of Pacemaker::Resource::Primitive was being mocked to return true. The fix requires re-invoking Pacemaker::CIBObject.from_name after attempting to create the new primitive, so that cib_object.exists? accurately reflects whether the creation succeeded. However, testing this required mocking Mixlib::Shellout#stdout to first return "" and then secondly a definition string for the created resource, and unfortunately this exposed a nasty bug in rspec-mocks: https://github.com/rspec/rspec-mocks/issues/559 So we revamp the mocking of Mixlib::Shellout#stdout to use doubles instead of #expect_any_instance_of.
74 lines
2.2 KiB
Ruby
74 lines
2.2 KiB
Ruby
# Shared code used to test providers of CIB objects
|
|
|
|
require 'mixlib/shellout'
|
|
|
|
require File.expand_path('../../libraries/pacemaker/cib_object',
|
|
File.dirname(__FILE__))
|
|
|
|
shared_examples "a CIB object" do
|
|
def expect_to_match_fixture(obj)
|
|
expect(obj.is_a? pacemaker_object_class).to eq(true)
|
|
fields.each do |field|
|
|
method = field.to_sym
|
|
expect(obj.send(method)).to eq(fixture.send(method))
|
|
end
|
|
end
|
|
|
|
it "should be instantiated via Pacemaker::CIBObject.from_name" do
|
|
expect_definitions(fixture.definition_string)
|
|
obj = Pacemaker::CIBObject.from_name(fixture.name)
|
|
expect_to_match_fixture(obj)
|
|
end
|
|
|
|
it "should instantiate by parsing a definition" do
|
|
obj = Pacemaker::CIBObject.from_definition(fixture.definition_string)
|
|
expect_to_match_fixture(obj)
|
|
end
|
|
|
|
it "should barf if the loaded definition's type is not colocation" do
|
|
expect_definitions("clone foo blah blah")
|
|
expect { fixture.load_definition }.to \
|
|
raise_error(Pacemaker::CIBObject::TypeMismatch,
|
|
"Expected #{object_type} type but loaded definition was type clone")
|
|
end
|
|
end
|
|
|
|
shared_examples "action on non-existent resource" do |action, cmd, expected_error|
|
|
it "should not attempt to #{action.to_s} a non-existent resource" do
|
|
expect_definitions("")
|
|
|
|
if expected_error
|
|
expect { provider.run_action action }.to \
|
|
raise_error(RuntimeError, expected_error)
|
|
else
|
|
provider.run_action action
|
|
end
|
|
|
|
expect(@chef_run).not_to run_execute(cmd)
|
|
expect(@resource).not_to be_updated
|
|
end
|
|
end
|
|
|
|
module Chef::RSpec
|
|
module Pacemaker
|
|
module CIBObject
|
|
# "crm configure show" is executed by load_current_resource, and
|
|
# again later on for the :create action, to see whether to create or
|
|
# modify.
|
|
def shellout_double(definition)
|
|
shellout = double(Mixlib::ShellOut)
|
|
shellout.stub(:environment).and_return({})
|
|
shellout.stub(:run_command)
|
|
shellout.stub(:error!)
|
|
expect(shellout).to receive(:stdout).and_return(definition)
|
|
shellout
|
|
end
|
|
|
|
def expect_definitions(*definitions)
|
|
doubles = definitions.map { |d| shellout_double(d) }
|
|
Mixlib::ShellOut.stub(:new).and_return(*doubles)
|
|
end
|
|
end
|
|
end
|
|
end
|