extract #copy_attrs_from_chef_resource

libraries/pacemaker/cib_object.rb

@@ -62,6 +62,15 @@ module Pacemaker
       @definition = nil
     end
 
+    def copy_attrs_from_chef_resource(resource, *attrs)
+      attrs.each do |attr|
+        value = resource.send(attr.to_sym)
+        writer = (attr + '=').to_sym
+        send(writer, value)
+      end
+      self
+    end
+
     def load_definition
       @definition = self.class.get_definition(name)
 

libraries/pacemaker/resource/primitive.rb

@@ -15,13 +15,7 @@ class Pacemaker::Resource::Primitive < Pacemaker::Resource
   end
 
   def self.from_chef_resource(resource)
-    primitive = new(resource.name)
+    new(resource.name).copy_attrs_from_chef_resource(resource, *%w(agent params meta op))
-    %w(agent params meta op).each do |data|
-      value = resource.send(data.to_sym)
-      writer = (data + '=').to_sym
-      primitive.send(writer, value)
-    end
-    return primitive
   end
 
   def parse_definition