6679a3853a
Previously, our compute base class overwrote some clients with their admin versions. This is needlessly confusing. This patch just removes the setup_clients() method altogether, along with the create_test_server() override, and forces tests to explicitly use either self.os_primary or self.os_admin as the clients. This change has a few simple but widespread consequences: * We need to start using self.get_host_for_server() in a few places, instead of looking up the 'OS-EXT-SRV-ATTR:host' attribute in the server dict, as that's only present in the admin response. * We can drop the public visibility in copy_default_image(), as that's only allowed for admins, and the default shared visibility should work just as well for us. * The unit test for list_compute_hosts() would need to get fixed to account for the use of self.os_admin.services_client instead of self.services_client. Rather than do that, just drop the test entirely, it adds no value as list_compute_hosts() is used in whitebox tests themselves. * We need to start explicitly plassing wait_until='ACTIVE' to every one of our create_test_server calls, as the override used to do that for us. * Our live_migrate() helper now needs to be passed a clients manager so that it can pass that through to the waiter when waiting for the server to reach a particular status after the live migration. Depends-on: https://review.opendev.org/c/openstack/tempest/+/820062 Change-Id: I8d5be63275bd8a28b7012e14b99cadafdea53a47
77 lines
3.1 KiB
Python
77 lines
3.1 KiB
Python
|
|
# Copyright 2021 Red Hat Inc.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from oslo_log import log as logging
|
|
from tempest import config
|
|
|
|
from whitebox_tempest_plugin.api.compute import base
|
|
from whitebox_tempest_plugin.services import clients
|
|
from whitebox_tempest_plugin.utils import get_ctlplane_address
|
|
|
|
CONF = config.CONF
|
|
LOG = logging.getLogger(__name__)
|
|
|
|
|
|
class TestRBDDirectDownload(base.BaseWhiteboxComputeTest):
|
|
"""Test validating RBD direct download configuration
|
|
and logs
|
|
"""
|
|
|
|
@classmethod
|
|
def skip_checks(cls):
|
|
super(TestRBDDirectDownload, cls).skip_checks()
|
|
if not CONF.compute_feature_enabled.rbd_download:
|
|
skip_msg = ("%s skipped as rbd-download is "
|
|
"not enabled" % cls.__name__)
|
|
raise cls.skipException(skip_msg)
|
|
|
|
def test_rbd_logs_and_conf(self):
|
|
base_server = self.create_test_server(wait_until='ACTIVE')
|
|
image = self.create_image_from_server(
|
|
base_server['id'],
|
|
name='base-server-img',
|
|
wait_until='ACTIVE'
|
|
)
|
|
# Creating a server from above image ensures a fresh
|
|
# attempt is made to download an image from the rbd
|
|
# pool to the local compute
|
|
server = self.create_test_server(wait_until='ACTIVE',
|
|
image_id=image['id'])
|
|
|
|
# Grab image id from newly created server
|
|
detailed_server_data = \
|
|
self.os_admin.servers_client.show_server(server['id'])['server']
|
|
image_id = detailed_server_data['image']['id']
|
|
|
|
host = self.get_host_for_server(server['id'])
|
|
host_sm = clients.NovaServiceManager(host, 'nova-compute',
|
|
self.os_admin.services_client)
|
|
rbd_pool = host_sm.get_conf_opt('glance', 'rbd_pool')
|
|
# Assert RBD direct download conf options
|
|
self.assertEqual('images', rbd_pool)
|
|
self.assertTrue(host_sm.get_conf_opt('glance', 'enable_rbd_download'))
|
|
log_query_string = f"Attempting to export RBD image: " \
|
|
f"[[]pool_name: {rbd_pool}[]] [[]image_uuid: " \
|
|
f"{image_id}[]]"
|
|
host_ip = get_ctlplane_address(host)
|
|
logs_client = clients.LogParserClient(host_ip)
|
|
# Assert if log with specified image is found
|
|
self.assertTrue(len(logs_client.parse(log_query_string)))
|
|
path = self.get_server_blockdevice_path(server['id'], 'vda')
|
|
# Assert image disk is present in ephemeral
|
|
# instances_path and not in rbd
|
|
self.assertIsNotNone(path) and self.assertNotIn('rbd', path)
|