Stephen Finucane b0fe724caf tests: Remove use of legacy resource helpers
This allows us to remove get_servers, create_servers, and
create_one_servers.

Change-Id: I31a86b6333fdc3da1b54407f077873511260a5df
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-14 14:10:55 +01:00

202 lines
6.1 KiB
Python

# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
from unittest import mock
from osc_lib.cli import format_columns
from osc_lib import exceptions
from osc_lib import utils as common_utils
from openstackclient.compute.v2 import server_backup
from openstackclient.tests.unit.compute.v2 import fakes as compute_fakes
from openstackclient.tests.unit.image.v2 import fakes as image_fakes
class TestServerBackupCreate(compute_fakes.TestComputev2):
def image_columns(self, image):
columnlist = (
'id',
'name',
'owner',
'protected',
'status',
'tags',
'visibility',
)
return columnlist
def image_data(self, image):
datalist = (
image['id'],
image['name'],
image['owner_id'],
image['is_protected'],
'active',
format_columns.ListColumn(image.get('tags')),
image['visibility'],
)
return datalist
def setUp(self):
super().setUp()
self.server = compute_fakes.create_one_sdk_server()
self.compute_client.find_server.return_value = self.server
self.image = image_fakes.create_one_image(
{'name': self.server.name, 'status': 'active'}
)
self.image_client.find_image.return_value = self.image
# Get the command object to test
self.cmd = server_backup.CreateServerBackup(self.app, None)
def test_server_backup_defaults(self):
arglist = [
self.server.id,
]
verifylist = [
('name', None),
('type', None),
('rotate', None),
('wait', False),
('server', self.server.id),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
# In base command class ShowOne in cliff, abstract method take_action()
# returns a two-part tuple with a tuple of column names and a tuple of
# data to be shown.
columns, data = self.cmd.take_action(parsed_args)
self.compute_client.backup_server.assert_called_with(
self.server.id,
self.server.name,
'',
1,
)
self.assertEqual(self.image_columns(self.image), columns)
self.assertCountEqual(self.image_data(self.image), data)
def test_server_backup_create_options(self):
arglist = [
'--name',
'image',
'--type',
'daily',
'--rotate',
'2',
self.server.id,
]
verifylist = [
('name', 'image'),
('type', 'daily'),
('rotate', 2),
('server', self.server.id),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
# In base command class ShowOne in cliff, abstract method take_action()
# returns a two-part tuple with a tuple of column names and a tuple of
# data to be shown.
columns, data = self.cmd.take_action(parsed_args)
self.compute_client.backup_server.assert_called_with(
self.server.id,
'image',
'daily',
2,
)
self.assertEqual(self.image_columns(self.image), columns)
self.assertCountEqual(self.image_data(self.image), data)
@mock.patch.object(common_utils, 'wait_for_status', return_value=False)
def test_server_backup_wait_fail(self, mock_wait_for_status):
self.image_client.get_image.return_value = self.image
arglist = [
'--name',
'image',
'--type',
'daily',
'--wait',
self.server.id,
]
verifylist = [
('name', 'image'),
('type', 'daily'),
('wait', True),
('server', self.server.id),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
self.assertRaises(
exceptions.CommandError,
self.cmd.take_action,
parsed_args,
)
self.compute_client.backup_server.assert_called_with(
self.server.id,
'image',
'daily',
1,
)
mock_wait_for_status.assert_called_once_with(
self.image_client.get_image, self.image.id, callback=mock.ANY
)
@mock.patch.object(common_utils, 'wait_for_status', return_value=True)
def test_server_backup_wait_ok(self, mock_wait_for_status):
self.image_client.get_image = mock.Mock(
side_effect=self.image,
)
arglist = [
'--name',
'image',
'--type',
'daily',
'--wait',
self.server.id,
]
verifylist = [
('name', 'image'),
('type', 'daily'),
('wait', True),
('server', self.server.id),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
# In base command class ShowOne in cliff, abstract method take_action()
# returns a two-part tuple with a tuple of column names and a tuple of
# data to be shown.
columns, data = self.cmd.take_action(parsed_args)
self.compute_client.backup_server.assert_called_with(
self.server.id,
'image',
'daily',
1,
)
mock_wait_for_status.assert_called_once_with(
self.image_client.get_image, self.image.id, callback=mock.ANY
)
self.assertEqual(self.image_columns(self.image), columns)
self.assertCountEqual(self.image_data(self.image), data)