whoami-rajat 4dfbc5011e Migrate 'volume summary' command to SDK
This patch modifies the existing volume summary call from
cinderclient to SDK.

Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/884397
Change-Id: I364211a597b6ec155b154fa9d3c67239e750b5ad
2023-07-05 10:04:01 +00:00

199 lines
6.4 KiB
Python

#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
import copy
from unittest import mock
from cinderclient import api_versions
from openstack import utils as sdk_utils
from osc_lib.cli import format_columns
from osc_lib import exceptions
from openstackclient.tests.unit.volume.v2 import fakes as volume_fakes
from openstackclient.tests.unit.volume.v3 import fakes as v3_fakes
from openstackclient.volume.v3 import volume
class BaseVolumeTest(volume_fakes.TestVolume):
def setUp(self):
super().setUp()
self.app.client_manager.sdk_connection = mock.Mock()
self.app.client_manager.sdk_connection.volume = mock.Mock()
self.sdk_client = self.app.client_manager.sdk_connection.volume
patcher = mock.patch.object(
sdk_utils, 'supports_microversion', return_value=True
)
self.addCleanup(patcher.stop)
self.supports_microversion_mock = patcher.start()
self._set_mock_microversion(
self.app.client_manager.volume.api_version.get_string()
)
def _set_mock_microversion(self, mock_v):
"""Set a specific microversion for the mock supports_microversion()."""
self.supports_microversion_mock.reset_mock(return_value=True)
self.supports_microversion_mock.side_effect = (
lambda _, v: api_versions.APIVersion(v)
<= api_versions.APIVersion(mock_v)
)
class TestVolumeSummary(BaseVolumeTest):
columns = [
'Total Count',
'Total Size',
]
def setUp(self):
super().setUp()
self.mock_vol_1 = volume_fakes.create_one_volume()
self.mock_vol_2 = volume_fakes.create_one_volume()
block_storage_summary = v3_fakes.get_one_block_storage_summary(
self.mock_vol_1.size + self.mock_vol_2.size
)
self.sdk_client.summary.return_value = block_storage_summary
# Get the command object to test
self.cmd = volume.VolumeSummary(self.app, None)
def test_volume_summary(self):
self._set_mock_microversion('3.12')
arglist = [
'--all-projects',
]
verifylist = [
('all_projects', True),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
columns, data = self.cmd.take_action(parsed_args)
self.sdk_client.summary.assert_called_once_with(True)
self.assertEqual(self.columns, columns)
datalist = (2, self.mock_vol_1.size + self.mock_vol_2.size)
self.assertCountEqual(datalist, tuple(data))
def test_volume_summary_pre_312(self):
arglist = [
'--all-projects',
]
verifylist = [
('all_projects', True),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
exc = self.assertRaises(
exceptions.CommandError, self.cmd.take_action, parsed_args
)
self.assertIn(
'--os-volume-api-version 3.12 or greater is required', str(exc)
)
def test_volume_summary_with_metadata(self):
self._set_mock_microversion('3.36')
combine_meta = {**self.mock_vol_1.metadata, **self.mock_vol_2.metadata}
block_storage_summary = v3_fakes.get_one_block_storage_summary(
self.mock_vol_1.size + self.mock_vol_2.size, metadata=combine_meta
)
self.sdk_client.summary.return_value = block_storage_summary
new_cols = copy.deepcopy(self.columns)
new_cols.extend(['Metadata'])
arglist = [
'--all-projects',
]
verifylist = [
('all_projects', True),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
columns, data = self.cmd.take_action(parsed_args)
self.sdk_client.summary.assert_called_once_with(True)
self.assertEqual(new_cols, columns)
datalist = (
2,
self.mock_vol_1.size + self.mock_vol_2.size,
format_columns.DictColumn(combine_meta),
)
self.assertCountEqual(datalist, tuple(data))
class TestVolumeRevertToSnapshot(BaseVolumeTest):
def setUp(self):
super().setUp()
self.mock_volume = volume_fakes.create_one_volume()
self.mock_snapshot = volume_fakes.create_one_snapshot(
attrs={'volume_id': self.mock_volume.id}
)
# Get the command object to test
self.cmd = volume.VolumeRevertToSnapshot(self.app, None)
def test_volume_revert_to_snapshot_pre_340(self):
arglist = [
self.mock_snapshot.id,
]
verifylist = [
('snapshot', self.mock_snapshot.id),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
exc = self.assertRaises(
exceptions.CommandError, self.cmd.take_action, parsed_args
)
self.assertIn(
'--os-volume-api-version 3.40 or greater is required', str(exc)
)
def test_volume_revert_to_snapshot(self):
self._set_mock_microversion('3.40')
arglist = [
self.mock_snapshot.id,
]
verifylist = [
('snapshot', self.mock_snapshot.id),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
with mock.patch.object(
self.sdk_client, 'find_volume', return_value=self.mock_volume
), mock.patch.object(
self.sdk_client, 'find_snapshot', return_value=self.mock_snapshot
):
self.cmd.take_action(parsed_args)
self.sdk_client.revert_volume_to_snapshot.assert_called_once_with(
self.mock_volume,
self.mock_snapshot,
)
self.sdk_client.find_volume.assert_called_with(
self.mock_volume.id,
ignore_missing=False,
)
self.sdk_client.find_snapshot.assert_called_with(
self.mock_snapshot.id,
ignore_missing=False,
)