openstack/python-openstackclient
Code Issues Proposed changes
python-openstackclient/openstackclient/tests/unit/compute/v2/test_server_group.py
Stephen Finucane dc68be6b7b tests: Rename 'compute_sdk_client' -> 'compute_client' 
Resolve a TODO. Achieved using:

  sed -i 's/self.compute_sdk_client/self.compute_client/' \
    $(ag -w self.compute_sdk_client -l)

Change-Id: I76798058b9dee9fc7ef01ff8656543fbb1266d43
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-04-03 16:39:04 +01:00

467 lines
15 KiB
Python
Raw Blame History

# Copyright 2016 Huawei, Inc. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
from openstack.compute.v2 import server_group as _server_group
from openstack.test import fakes as sdk_fakes
from osc_lib.cli import format_columns
from osc_lib import exceptions
from openstackclient.compute.v2 import server_group
from openstackclient.tests.unit.compute.v2 import fakes as compute_fakes
from openstackclient.tests.unit import utils as tests_utils
class TestServerGroup(compute_fakes.TestComputev2):
def setUp(self):
super().setUp()
self.fake_server_group = sdk_fakes.generate_fake_resource(
_server_group.ServerGroup
)
self.columns = (
'id',
'members',
'name',
'policy',
'project_id',
'rules',
'user_id',
)
self.data = (
self.fake_server_group.id,
format_columns.ListColumn(self.fake_server_group.member_ids),
self.fake_server_group.name,
self.fake_server_group.policy,
self.fake_server_group.project_id,
format_columns.DictColumn(self.fake_server_group.rules),
self.fake_server_group.user_id,
)
class TestServerGroupCreate(TestServerGroup):
def setUp(self):
super().setUp()
self.compute_client.create_server_group.return_value = (
self.fake_server_group
)
self.cmd = server_group.CreateServerGroup(self.app, None)
def test_server_group_create(self):
self.set_compute_api_version('2.64')
arglist = [
'--policy',
'anti-affinity',
'affinity_group',
]
verifylist = [
('policy', 'anti-affinity'),
('name', 'affinity_group'),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
columns, data = self.cmd.take_action(parsed_args)
self.compute_client.create_server_group.assert_called_once_with(
name=parsed_args.name,
policy=parsed_args.policy,
)
self.assertCountEqual(self.columns, columns)
self.assertCountEqual(self.data, data)
def test_server_group_create_with_soft_policies(self):
self.set_compute_api_version('2.64')
arglist = [
'--policy',
'soft-anti-affinity',
'affinity_group',
]
verifylist = [
('policy', 'soft-anti-affinity'),
('name', 'affinity_group'),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
columns, data = self.cmd.take_action(parsed_args)
self.compute_client.create_server_group.assert_called_once_with(
name=parsed_args.name,
policy=parsed_args.policy,
)
self.assertCountEqual(self.columns, columns)
self.assertCountEqual(self.data, data)
def test_server_group_create_with_soft_policies_pre_v215(self):
self.set_compute_api_version('2.14')
arglist = [
'--policy',
'soft-anti-affinity',
'affinity_group',
]
verifylist = [
('policy', 'soft-anti-affinity'),
('name', 'affinity_group'),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
ex = self.assertRaises(
exceptions.CommandError, self.cmd.take_action, parsed_args
)
self.assertIn(
'--os-compute-api-version 2.15 or greater is required', str(ex)
)
def test_server_group_create_with_rules(self):
self.set_compute_api_version('2.64')
arglist = [
'--policy',
'soft-anti-affinity',
'--rule',
'max_server_per_host=2',
'affinity_group',
]
verifylist = [
('policy', 'soft-anti-affinity'),
('rules', {'max_server_per_host': '2'}),
('name', 'affinity_group'),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
columns, data = self.cmd.take_action(parsed_args)
self.compute_client.create_server_group.assert_called_once_with(
name=parsed_args.name,
policy=parsed_args.policy,
rules=parsed_args.rules,
)
self.assertCountEqual(self.columns, columns)
self.assertCountEqual(self.data, data)
def test_server_group_create_with_rules_pre_v264(self):
self.set_compute_api_version('2.63')
arglist = [
'--policy',
'soft-anti-affinity',
'--rule',
'max_server_per_host=2',
'affinity_group',
]
verifylist = [
('policy', 'soft-anti-affinity'),
('rules', {'max_server_per_host': '2'}),
('name', 'affinity_group'),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
ex = self.assertRaises(
exceptions.CommandError, self.cmd.take_action, parsed_args
)
self.assertIn(
'--os-compute-api-version 2.64 or greater is required', str(ex)
)
class TestServerGroupDelete(TestServerGroup):
def setUp(self):
super().setUp()
self.compute_client.find_server_group.return_value = (
self.fake_server_group
)
self.cmd = server_group.DeleteServerGroup(self.app, None)
def test_server_group_delete(self):
arglist = [
'affinity_group',
]
verifylist = [
('server_group', ['affinity_group']),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
result = self.cmd.take_action(parsed_args)
self.compute_client.find_server_group.assert_called_once_with(
'affinity_group', ignore_missing=False
)
self.compute_client.delete_server_group.assert_called_once_with(
self.fake_server_group.id
)
self.assertIsNone(result)
def test_server_group_multiple_delete(self):
arglist = ['affinity_group', 'anti_affinity_group']
verifylist = [
('server_group', ['affinity_group', 'anti_affinity_group']),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
result = self.cmd.take_action(parsed_args)
self.compute_client.find_server_group.assert_any_call(
'affinity_group', ignore_missing=False
)
self.compute_client.find_server_group.assert_any_call(
'anti_affinity_group', ignore_missing=False
)
self.compute_client.delete_server_group.assert_called_with(
self.fake_server_group.id
)
self.assertEqual(2, self.compute_client.find_server_group.call_count)
self.assertEqual(2, self.compute_client.delete_server_group.call_count)
self.assertIsNone(result)
def test_server_group_delete_no_input(self):
arglist = []
verifylist = None
self.assertRaises(
tests_utils.ParserException,
self.check_parser,
self.cmd,
arglist,
verifylist,
)
def test_server_group_multiple_delete_with_exception(self):
arglist = ['affinity_group', 'anti_affinity_group']
verifylist = [
('server_group', ['affinity_group', 'anti_affinity_group']),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
self.compute_client.find_server_group.side_effect = [
self.fake_server_group,
exceptions.CommandError,
]
try:
self.cmd.take_action(parsed_args)
self.fail('CommandError should be raised.')
except exceptions.CommandError as e:
self.assertEqual('1 of 2 server groups failed to delete.', str(e))
self.compute_client.find_server_group.assert_any_call(
'affinity_group', ignore_missing=False
)
self.compute_client.find_server_group.assert_any_call(
'anti_affinity_group', ignore_missing=False
)
self.assertEqual(2, self.compute_client.find_server_group.call_count)
self.compute_client.delete_server_group.assert_called_once_with(
self.fake_server_group.id
)
class TestServerGroupList(TestServerGroup):
def setUp(self):
super().setUp()
self.compute_client.server_groups.return_value = [
self.fake_server_group
]
self.cmd = server_group.ListServerGroup(self.app, None)
def test_server_group_list(self):
arglist = []
verifylist = [
('all_projects', False),
('long', False),
('limit', None),
('offset', None),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
columns, data = self.cmd.take_action(parsed_args)
self.compute_client.server_groups.assert_called_once_with()
expected_columns = (
'ID',
'Name',
'Policies',
)
expected_data = (
(
self.fake_server_group.id,
self.fake_server_group.name,
format_columns.ListColumn(self.fake_server_group.policies),
),
)
self.assertCountEqual(expected_columns, columns)
self.assertCountEqual(expected_data, tuple(data))
def test_server_group_list_with_all_projects_and_long(self):
arglist = [
'--all-projects',
'--long',
]
verifylist = [
('all_projects', True),
('long', True),
('limit', None),
('offset', None),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
columns, data = self.cmd.take_action(parsed_args)
self.compute_client.server_groups.assert_called_once_with(
all_projects=True
)
expected_columns = (
'ID',
'Name',
'Policies',
'Members',
'Project Id',
'User Id',
)
expected_data = (
(
self.fake_server_group.id,
self.fake_server_group.name,
format_columns.ListColumn(self.fake_server_group.policies),
format_columns.ListColumn(self.fake_server_group.member_ids),
self.fake_server_group.project_id,
self.fake_server_group.user_id,
),
)
self.assertCountEqual(expected_columns, columns)
self.assertCountEqual(expected_data, tuple(data))
def test_server_group_list_with_limit(self):
arglist = [
'--limit',
'1',
]
verifylist = [
('all_projects', False),
('long', False),
('limit', 1),
('offset', None),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
self.cmd.take_action(parsed_args)
self.compute_client.server_groups.assert_called_once_with(limit=1)
def test_server_group_list_with_offset(self):
arglist = [
'--offset',
'5',
]
verifylist = [
('all_projects', False),
('long', False),
('limit', None),
('offset', 5),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
self.cmd.take_action(parsed_args)
self.compute_client.server_groups.assert_called_once_with(offset=5)
def test_server_group_list_v264(self):
self.set_compute_api_version('2.64')
arglist = []
verifylist = [
('all_projects', False),
('long', False),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
columns, data = self.cmd.take_action(parsed_args)
self.compute_client.server_groups.assert_called_once_with()
expected_columns = (
'ID',
'Name',
'Policy',
)
expected_data = (
(
self.fake_server_group.id,
self.fake_server_group.name,
self.fake_server_group.policy,
),
)
self.assertCountEqual(expected_columns, columns)
self.assertCountEqual(expected_data, tuple(data))
def test_server_group_list_with_all_projects_and_long_v264(self):
self.set_compute_api_version('2.64')
arglist = [
'--all-projects',
'--long',
]
verifylist = [
('all_projects', True),
('long', True),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
columns, data = self.cmd.take_action(parsed_args)
self.compute_client.server_groups.assert_called_once_with(
all_projects=True
)
expected_columns = (
'ID',
'Name',
'Policy',
'Members',
'Project Id',
'User Id',
)
expected_data = (
(
self.fake_server_group.id,
self.fake_server_group.name,
self.fake_server_group.policy,
format_columns.ListColumn(self.fake_server_group.member_ids),
self.fake_server_group.project_id,
self.fake_server_group.user_id,
),
)
self.assertCountEqual(expected_columns, columns)
self.assertCountEqual(expected_data, tuple(data))
class TestServerGroupShow(TestServerGroup):
def setUp(self):
super().setUp()
self.compute_client.find_server_group.return_value = (
self.fake_server_group
)
self.cmd = server_group.ShowServerGroup(self.app, None)
def test_server_group_show(self):
self.set_compute_api_version('2.64')
arglist = [
'affinity_group',
]
verifylist = [
('server_group', 'affinity_group'),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
columns, data = self.cmd.take_action(parsed_args)
self.assertCountEqual(self.columns, columns)
self.assertCountEqual(self.data, data)
View Git Blame Copy Permalink