28b1267921
This removes the need for a number of base test case subclasses. We use 'image_client' rather than 'client' to avoid conflicts with clients for other services. Note that this highlights a minor bug with the 'volume create' command when using the v1 block storage API and creating a volume from an image. This is corrected, though it can be assumed that no one is actually using this code path to say it hasn't been reported in the few years since the bug was introduced in Ussuri. Change-Id: I571be27f68bb7669dcb883f3b4799731b4a35479 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
226 lines
7.1 KiB
Python
226 lines
7.1 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
from unittest import mock
|
|
|
|
from osc_lib.cli import format_columns
|
|
from osc_lib import exceptions
|
|
from osc_lib import utils as common_utils
|
|
|
|
from openstackclient.compute.v2 import server_image
|
|
from openstackclient.tests.unit.compute.v2 import fakes as compute_fakes
|
|
from openstackclient.tests.unit.image.v2 import fakes as image_fakes
|
|
|
|
|
|
class TestServerImage(compute_fakes.TestComputev2):
|
|
def setUp(self):
|
|
super().setUp()
|
|
|
|
# Get a shortcut to the compute client ServerManager Mock
|
|
self.app.client_manager.sdk_connection = mock.Mock()
|
|
self.app.client_manager.sdk_connection.compute = mock.Mock()
|
|
self.sdk_client = self.app.client_manager.sdk_connection.compute
|
|
|
|
# Set object attributes to be tested. Could be overwritten in subclass.
|
|
self.attrs = {}
|
|
|
|
def setup_servers_mock(self, count):
|
|
servers = compute_fakes.create_sdk_servers(
|
|
attrs=self.attrs,
|
|
count=count,
|
|
)
|
|
|
|
# This is the return value for compute_client.find_server()
|
|
self.sdk_client.find_server = compute_fakes.get_servers(
|
|
servers,
|
|
0,
|
|
)
|
|
return servers
|
|
|
|
|
|
class TestServerImageCreate(TestServerImage):
|
|
def image_columns(self, image):
|
|
# columnlist = tuple(sorted(image.keys()))
|
|
columnlist = (
|
|
'id',
|
|
'name',
|
|
'owner',
|
|
'protected',
|
|
'status',
|
|
'tags',
|
|
'visibility',
|
|
)
|
|
return columnlist
|
|
|
|
def image_data(self, image):
|
|
datalist = (
|
|
image['id'],
|
|
image['name'],
|
|
image['owner_id'],
|
|
image['is_protected'],
|
|
'active',
|
|
format_columns.ListColumn(image.get('tags')),
|
|
image['visibility'],
|
|
)
|
|
return datalist
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
|
|
# Get the command object to test
|
|
self.cmd = server_image.CreateServerImage(self.app, None)
|
|
|
|
def setup_images_mock(self, count, servers=None):
|
|
if servers:
|
|
images = image_fakes.create_images(
|
|
attrs={
|
|
'name': servers[0].name,
|
|
'status': 'active',
|
|
},
|
|
count=count,
|
|
)
|
|
else:
|
|
images = image_fakes.create_images(
|
|
attrs={
|
|
'status': 'active',
|
|
},
|
|
count=count,
|
|
)
|
|
|
|
self.image_client.find_image = mock.Mock(side_effect=images)
|
|
self.sdk_client.create_server_image = mock.Mock(
|
|
return_value=images[0],
|
|
)
|
|
return images
|
|
|
|
def test_server_image_create_defaults(self):
|
|
servers = self.setup_servers_mock(count=1)
|
|
images = self.setup_images_mock(count=1, servers=servers)
|
|
|
|
arglist = [
|
|
servers[0].id,
|
|
]
|
|
verifylist = [
|
|
('server', servers[0].id),
|
|
]
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
|
|
# In base command class ShowOne in cliff, abstract method take_action()
|
|
# returns a two-part tuple with a tuple of column names and a tuple of
|
|
# data to be shown.
|
|
columns, data = self.cmd.take_action(parsed_args)
|
|
|
|
self.sdk_client.create_server_image.assert_called_with(
|
|
servers[0].id,
|
|
servers[0].name,
|
|
None,
|
|
)
|
|
|
|
self.assertEqual(self.image_columns(images[0]), columns)
|
|
self.assertCountEqual(self.image_data(images[0]), data)
|
|
|
|
def test_server_image_create_options(self):
|
|
servers = self.setup_servers_mock(count=1)
|
|
images = self.setup_images_mock(count=1, servers=servers)
|
|
|
|
arglist = [
|
|
'--name',
|
|
'img-nam',
|
|
'--property',
|
|
'key=value',
|
|
servers[0].id,
|
|
]
|
|
verifylist = [
|
|
('name', 'img-nam'),
|
|
('server', servers[0].id),
|
|
('properties', {'key': 'value'}),
|
|
]
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
|
|
# In base command class ShowOne in cliff, abstract method take_action()
|
|
# returns a two-part tuple with a tuple of column names and a tuple of
|
|
# data to be shown.
|
|
columns, data = self.cmd.take_action(parsed_args)
|
|
|
|
self.sdk_client.create_server_image.assert_called_with(
|
|
servers[0].id,
|
|
'img-nam',
|
|
{'key': 'value'},
|
|
)
|
|
|
|
self.assertEqual(self.image_columns(images[0]), columns)
|
|
self.assertCountEqual(self.image_data(images[0]), data)
|
|
|
|
@mock.patch.object(common_utils, 'wait_for_status', return_value=False)
|
|
def test_server_create_image_wait_fail(self, mock_wait_for_status):
|
|
servers = self.setup_servers_mock(count=1)
|
|
images = self.setup_images_mock(count=1, servers=servers)
|
|
|
|
arglist = [
|
|
'--wait',
|
|
servers[0].id,
|
|
]
|
|
verifylist = [
|
|
('wait', True),
|
|
('server', servers[0].id),
|
|
]
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
|
|
self.assertRaises(
|
|
exceptions.CommandError,
|
|
self.cmd.take_action,
|
|
parsed_args,
|
|
)
|
|
|
|
self.sdk_client.create_server_image.assert_called_with(
|
|
servers[0].id,
|
|
servers[0].name,
|
|
None,
|
|
)
|
|
|
|
mock_wait_for_status.assert_called_once_with(
|
|
self.image_client.get_image, images[0].id, callback=mock.ANY
|
|
)
|
|
|
|
@mock.patch.object(common_utils, 'wait_for_status', return_value=True)
|
|
def test_server_create_image_wait_ok(self, mock_wait_for_status):
|
|
servers = self.setup_servers_mock(count=1)
|
|
images = self.setup_images_mock(count=1, servers=servers)
|
|
|
|
arglist = [
|
|
'--wait',
|
|
servers[0].id,
|
|
]
|
|
verifylist = [
|
|
('wait', True),
|
|
('server', servers[0].id),
|
|
]
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
|
|
# In base command class ShowOne in cliff, abstract method take_action()
|
|
# returns a two-part tuple with a tuple of column names and a tuple of
|
|
# data to be shown.
|
|
columns, data = self.cmd.take_action(parsed_args)
|
|
|
|
self.sdk_client.create_server_image.assert_called_with(
|
|
servers[0].id,
|
|
servers[0].name,
|
|
None,
|
|
)
|
|
|
|
mock_wait_for_status.assert_called_once_with(
|
|
self.image_client.get_image, images[0].id, callback=mock.ANY
|
|
)
|
|
|
|
self.assertEqual(self.image_columns(images[0]), columns)
|
|
self.assertCountEqual(self.image_data(images[0]), data)
|