openstack/python-openstackclient
Code Issues Proposed changes

tests: Remove prints

Browse Source 
Change-Id: I35adac1199769fd73978b6457044191d02bb5bd4
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This commit is contained in:
Stephen Finucane 2023-11-13 17:29:35 +00:00
parent 1678f87d7a
commit d0d4077e1d
3 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openstackclient/tests/unit/identity/v3/test_trust.py
View File

@ -294,7 +294,6 @@ class TestTrustList(TestTrust):
# containing the data to be listed. # containing the data to be listed.
columns, data = self.cmd.take_action(parsed_args) columns, data = self.cmd.take_action(parsed_args)
print(self.trusts_mock.list.call_args_list)
self.trusts_mock.list.assert_any_call( self.trusts_mock.list.assert_any_call(
trustee_user=self.users_mock.get(), trustee_user=self.users_mock.get(),
trustor_user=None, trustor_user=None,
@ -335,7 +334,6 @@ class TestTrustList(TestTrust):
# containing the data to be listed. # containing the data to be listed.
columns, data = self.cmd.take_action(parsed_args) columns, data = self.cmd.take_action(parsed_args)
print(self.trusts_mock.list.call_args_list)
self.trusts_mock.list.assert_any_call( self.trusts_mock.list.assert_any_call(
trustor_user=self.users_mock.get(), trustor_user=self.users_mock.get(),
trustee_user=None, trustee_user=None,

2
openstackclient/tests/unit/integ/cli/test_shell.py
View File

@ -502,7 +502,6 @@ class TestIntegShellCliPrecedenceOCC(test_base.TestInteg):
) )
# +env, -cli, +occ # +env, -cli, +occ
print("auth_req: %s" % auth_req['auth'])
self.assertEqual( self.assertEqual(
test_shell.DEFAULT_USERNAME, test_shell.DEFAULT_USERNAME,
auth_req['auth']['identity']['password']['user']['name'], auth_req['auth']['identity']['password']['user']['name'],
@ -559,7 +558,6 @@ class TestIntegShellCliPrecedenceOCC(test_base.TestInteg):
) )
# +env, +cli, +occ # +env, +cli, +occ
print("auth_req: %s" % auth_req['auth'])
self.assertEqual( self.assertEqual(
'zarquon', 'zarquon',
auth_req['auth']['identity']['password']['user']['name'], auth_req['auth']['identity']['password']['user']['name'],

8
openstackclient/tests/unit/test_shell.py
View File

@ -141,10 +141,6 @@ class TestShell(osc_lib_test_utils.TestShell):
# Full name of the OpenStackShell class to test (cliff.app.App subclass) # Full name of the OpenStackShell class to test (cliff.app.App subclass)
shell_class_name = "openstackclient.shell.OpenStackShell" shell_class_name = "openstackclient.shell.OpenStackShell"
# TODO(dtroyer): remove this once the shell_class_patch patch is released
# in osc-lib
app_patch = shell_class_name
def setUp(self): def setUp(self):
super(TestShell, self).setUp() super(TestShell, self).setUp()
# TODO(dtroyer): remove this once the shell_class_patch patch is # TODO(dtroyer): remove this once the shell_class_patch patch is
@ -162,7 +158,6 @@ class TestShell(osc_lib_test_utils.TestShell):
) )
_cmd = cmd_options + " list role" _cmd = cmd_options + " list role"
osc_lib_test_utils.fake_execute(_shell, _cmd) osc_lib_test_utils.fake_execute(_shell, _cmd)
print("_shell: %s" % _shell)
self.app.assert_called_with(["list", "role"]) self.app.assert_called_with(["list", "role"])
self.assertEqual( self.assertEqual(
@ -178,7 +173,7 @@ class TestShell(osc_lib_test_utils.TestShell):
def _assert_token_auth(self, cmd_options, default_args): def _assert_token_auth(self, cmd_options, default_args):
with mock.patch( with mock.patch(
self.app_patch + ".initialize_app", self.shell_class_name + ".initialize_app",
self.app, self.app,
): ):
_shell = osc_lib_test_utils.make_shell( _shell = osc_lib_test_utils.make_shell(
@ -186,7 +181,6 @@ class TestShell(osc_lib_test_utils.TestShell):
) )
_cmd = cmd_options + " list role" _cmd = cmd_options + " list role"
osc_lib_test_utils.fake_execute(_shell, _cmd) osc_lib_test_utils.fake_execute(_shell, _cmd)
print("_shell: %s" % _shell)
self.app.assert_called_with(["list", "role"]) self.app.assert_called_with(["list", "role"])
self.assertEqual( self.assertEqual(