From f52e888dabaa75c7dde0faf7e121474ee3699f31 Mon Sep 17 00:00:00 2001 From: Rajat Dhasmana Date: Fri, 28 Jun 2024 20:30:56 +0530 Subject: [PATCH] Followup: Reduce LOC in volume v3 service This is a followup of[1] in which we are reducing LOC by removing redundant definition of columns. [1] https://review.opendev.org/c/openstack/python-openstackclient/+/922865 Change-Id: I2992d3ab678e751726906926b680e4aa9ad1d502 --- openstackclient/volume/v3/service.py | 29 ++++++++++------------------ 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/openstackclient/volume/v3/service.py b/openstackclient/volume/v3/service.py index 900aeab2d8..5f01b54562 100644 --- a/openstackclient/volume/v3/service.py +++ b/openstackclient/volume/v3/service.py @@ -25,30 +25,21 @@ class ListService(service_v2.ListService): def take_action(self, parsed_args): service_client = self.app.client_manager.volume - if parsed_args.long: - columns = [ - "Binary", - "Host", - "Zone", - "Status", - "State", - "Updated At", - "Disabled Reason", - ] - else: - columns = [ - "Binary", - "Host", - "Zone", - "Status", - "State", - "Updated At", - ] + columns = [ + "Binary", + "Host", + "Zone", + "Status", + "State", + "Updated At", + ] if service_client.api_version >= api_versions.APIVersion('3.7'): columns.append("Cluster") if service_client.api_version >= api_versions.APIVersion('3.49'): columns.append("Backend State") + if parsed_args.long: + columns.append("Disabled Reason") data = service_client.services.list( parsed_args.host, parsed_args.service