openstack/python-openstackclient
Code Issues Proposed changes

Handle NotFoundException when listing floating IPs

Browse Source 
Asking for floating IPs on an undercloud results in a NotFoundException.
Make openstackclient handle it gracefully.

No test is added for this because it would need to be a scenario test -
deploying a cloud without the foalting IP extension loaded.  I don't
think this edge case is worth an entire new job just to exercise it.

Change-Id: I73b544853376d98ab0dbb14e32fefc43c1a8a179
Story: 2006863
This commit is contained in:
Nate Johnston 2019-11-15 10:13:13 -05:00 committed by Stephen Finucane
parent 067261e80d
commit b0936c5b30
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
openstackclient/network/v2/floating_ip.py
View File

@ -12,6 +12,7 @@
"""IP Floating action implementations"""
from openstack import exceptions as sdk_exceptions
from osc_lib import utils
from osc_lib.utils import tags as _tag
@ -390,7 +391,10 @@ class ListFloatingIP(common.NetworkAndComputeLister):
_tag.get_tag_filtering_args(parsed_args, query)
data = client.ips(**query)
try:
data = list(client.ips(**query))
except sdk_exceptions.NotFoundException:
data = []
return (
headers,