openstack/python-openstackclient
Code Issues Proposed changes

Merge "Fix: incremental volume backup"

Browse Source
This commit is contained in:
Zuul 2024-07-05 19:55:12 +00:00 committed by Gerrit Code Review
commit a6dcb773f1
3 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
openstackclient/tests/unit/volume/v2/test_volume_backup.py
View File

@ -120,7 +120,7 @@ class TestBackupCreate(TestBackup):
name=self.new_backup.name, name=self.new_backup.name,
description=self.new_backup.description, description=self.new_backup.description,
force=True, force=True,
incremental=True, is_incremental=True,
snapshot_id=self.new_backup.snapshot_id, snapshot_id=self.new_backup.snapshot_id,
) )
self.assertEqual(self.columns, columns) self.assertEqual(self.columns, columns)
@ -150,7 +150,7 @@ class TestBackupCreate(TestBackup):
name=None, name=None,
description=None, description=None,
force=False, force=False,
incremental=False, is_incremental=False,
metadata={"foo": "bar", "wow": "much-cool"}, metadata={"foo": "bar", "wow": "much-cool"},
) )
self.assertEqual(self.columns, columns) self.assertEqual(self.columns, columns)
@ -199,7 +199,7 @@ class TestBackupCreate(TestBackup):
name=None, name=None,
description=None, description=None,
force=False, force=False,
incremental=False, is_incremental=False,
availability_zone="my-az", availability_zone="my-az",
) )
self.assertEqual(self.columns, columns) self.assertEqual(self.columns, columns)
@ -247,7 +247,7 @@ class TestBackupCreate(TestBackup):
name=None, name=None,
description=self.new_backup.description, description=self.new_backup.description,
force=False, force=False,
incremental=False, is_incremental=False,
) )
self.assertEqual(self.columns, columns) self.assertEqual(self.columns, columns)
self.assertEqual(self.data, data) self.assertEqual(self.data, data)

2
openstackclient/volume/v2/volume_backup.py
View File

@ -173,7 +173,7 @@ class CreateVolumeBackup(command.ShowOne):
name=parsed_args.name, name=parsed_args.name,
description=parsed_args.description, description=parsed_args.description,
force=parsed_args.force, force=parsed_args.force,
incremental=parsed_args.incremental, is_incremental=parsed_args.incremental,
**kwargs, **kwargs,
) )
data = utils.get_dict_properties(backup, columns) data = utils.get_dict_properties(backup, columns)

7
releasenotes/notes/fix-backup-incremental-d1c1e6886cf32256.yaml Normal file
View File

@ -0,0 +1,7 @@
---
fixes:
- |
Fixed issue with creating incremental volume backup.
Previously, ``incremental`` value was not passed in the
API request which is now included in the backup
create request.