From 91c4509afe1bdf89f89a40dfc0a3cb808fd2004a Mon Sep 17 00:00:00 2001 From: Reedip Date: Fri, 16 Sep 2016 13:39:54 +0530 Subject: [PATCH] Fix quota-update issue in LBaaS Currently L7Policies cannot be updated( it was missing in implementation in neutronclient). The same has been taken care in the current patch. Also, currently quota doesnt support updating the members in an LBaaS pool. This patch temporarily removes it, till it is not confirmed that LBaaS v2 needs to support quotas for members or not. Change-Id: I25a54a57debb762a32a280ece8c081fc52365f0f Closes-Bug: #1624097 --- openstackclient/common/quota.py | 2 +- openstackclient/tests/unit/common/test_quota.py | 6 +++--- openstackclient/tests/unit/network/v2/fakes.py | 1 + 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/openstackclient/common/quota.py b/openstackclient/common/quota.py index 4668e193e7..ebbf7ddf5b 100644 --- a/openstackclient/common/quota.py +++ b/openstackclient/common/quota.py @@ -74,8 +74,8 @@ NETWORK_QUOTAS = { 'rbac_policy': 'rbac-policies', 'vip': 'vips', 'subnetpool': 'subnetpools', - 'member': 'members', 'healthmonitor': 'health-monitors', + 'l7policy': 'l7policies', } diff --git a/openstackclient/tests/unit/common/test_quota.py b/openstackclient/tests/unit/common/test_quota.py index c43755bd05..294d772d1a 100644 --- a/openstackclient/tests/unit/common/test_quota.py +++ b/openstackclient/tests/unit/common/test_quota.py @@ -249,8 +249,8 @@ class TestQuotaSet(TestQuota): '--rbac-policies', str(network_fakes.QUOTA['rbac_policy']), '--ports', str(network_fakes.QUOTA['port']), '--vips', str(network_fakes.QUOTA['vip']), - '--members', str(network_fakes.QUOTA['member']), '--health-monitors', str(network_fakes.QUOTA['healthmonitor']), + '--l7policies', str(network_fakes.QUOTA['l7policy']), identity_fakes.project_name, ] verifylist = [ @@ -265,8 +265,8 @@ class TestQuotaSet(TestQuota): ('rbac_policy', network_fakes.QUOTA['rbac_policy']), ('port', network_fakes.QUOTA['port']), ('vip', network_fakes.QUOTA['vip']), - ('member', network_fakes.QUOTA['member']), ('healthmonitor', network_fakes.QUOTA['healthmonitor']), + ('l7policy', network_fakes.QUOTA['l7policy']), ] parsed_args = self.check_parser(self.cmd, arglist, verifylist) @@ -283,8 +283,8 @@ class TestQuotaSet(TestQuota): 'rbac_policy': network_fakes.QUOTA['rbac_policy'], 'port': network_fakes.QUOTA['port'], 'vip': network_fakes.QUOTA['vip'], - 'member': network_fakes.QUOTA['member'], 'healthmonitor': network_fakes.QUOTA['healthmonitor'], + 'l7policy': network_fakes.QUOTA['l7policy'], } self.network_mock.update_quota.assert_called_once_with( identity_fakes.project_id, diff --git a/openstackclient/tests/unit/network/v2/fakes.py b/openstackclient/tests/unit/network/v2/fakes.py index ec032c929d..4cc3512e9d 100644 --- a/openstackclient/tests/unit/network/v2/fakes.py +++ b/openstackclient/tests/unit/network/v2/fakes.py @@ -34,6 +34,7 @@ QUOTA = { "vip": 10, "member": 10, "healthmonitor": 10, + "l7policy": 5, }