openstack/python-openstackclient
Code Issues Proposed changes

volume: fix backup list of deleted volume

Browse Source 
When trying to list backups of a deleted volume with --volume,
openstackclient fails because the volume does not exist.
However, for listing a volume's backups, the volume itself
does not need to be present.

Fix this issue by allowing the volume of the requested backups
to not exist.

Story: 2009901
Task: 44716
Change-Id: Iea1a567151f427fa0e1ccff3af5cbeab620defcd
Signed-off-by: Jan Hartkopf <jhartkopf@inovex.de>
This commit is contained in:
Jan Hartkopf 2022-03-08 15:55:55 +01:00
parent 63452f362d
commit 8acead32ee
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
openstackclient/volume/v2/volume_backup.py
View File

@ -310,9 +310,17 @@ class ListVolumeBackup(command.Lister):
filter_volume_id = None filter_volume_id = None
if parsed_args.volume: if parsed_args.volume:
try:
filter_volume_id = utils.find_resource( filter_volume_id = utils.find_resource(
volume_client.volumes, parsed_args.volume, volume_client.volumes, parsed_args.volume,
).id ).id
except exceptions.CommandError:
# Volume with that ID does not exist, but search for backups
# for that volume nevertheless
LOG.debug("No volume with ID %s existing, continuing to "
"search for backups for that volume ID",
parsed_args.volume)
filter_volume_id = parsed_args.volume
marker_backup_id = None marker_backup_id = None
if parsed_args.marker: if parsed_args.marker: