From 84c83fc3aeebf8201a301f1864c3b8a1572111f1 Mon Sep 17 00:00:00 2001 From: Dean Troyer Date: Mon, 29 Aug 2016 18:14:26 -0500 Subject: [PATCH] Provide fallback prompt function for current osc-lib Leaving the pw_func uninitialize in osc-lib turned out to be a bad idea as the test to prompt in setup_auth() doesn't check for a callback of None. Also, release note Change-Id: I8f875fa8a942d02a040238359ee22c603a4e5956 --- openstackclient/common/clientmanager.py | 3 +++ releasenotes/notes/bug-1617384-55c88207115e2a5b.yaml | 5 +++++ 2 files changed, 8 insertions(+) create mode 100644 releasenotes/notes/bug-1617384-55c88207115e2a5b.yaml diff --git a/openstackclient/common/clientmanager.py b/openstackclient/common/clientmanager.py index 9097543b14..57423aed6b 100644 --- a/openstackclient/common/clientmanager.py +++ b/openstackclient/common/clientmanager.py @@ -20,6 +20,7 @@ import pkg_resources import sys from osc_lib import clientmanager +from osc_lib import shell LOG = logging.getLogger(__name__) @@ -48,6 +49,8 @@ class ClientManager(clientmanager.ClientManager): super(ClientManager, self).__init__( cli_options=cli_options, api_version=api_version, + # TODO(dtroyer): Remove this when osc-lib 1.2 is released + pw_func=shell.prompt_for_password, ) # TODO(dtroyer): For compatibility; mark this for removal when plugin diff --git a/releasenotes/notes/bug-1617384-55c88207115e2a5b.yaml b/releasenotes/notes/bug-1617384-55c88207115e2a5b.yaml new file mode 100644 index 0000000000..89b452be92 --- /dev/null +++ b/releasenotes/notes/bug-1617384-55c88207115e2a5b.yaml @@ -0,0 +1,5 @@ +--- +fixes: + - | + Fix prompting for password issue introduced in release 3.0.0 + [Bug `1617384 `_]