openstack/python-openstackclient
Code Issues Proposed changes

Merge "Enable some off-by-default checks"

Browse Source
This commit is contained in:
Jenkins 2017-07-20 18:08:32 +00:00 committed by Gerrit Code Review
commit 813e49db93
3 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
openstackclient/tests/functional/volume/v1/test_service.py
View File

@ -64,10 +64,7 @@ class VolumeServiceTests(common.BaseVolumeTests):
'enabled', 'enabled',
cmd_output[0]['Status'] cmd_output[0]['Status']
) )
self.assertEqual( self.assertIsNone(cmd_output[0]['Disabled Reason'])
None,
cmd_output[0]['Disabled Reason']
)
# Test volume service set --disable and --disable-reason # Test volume service set --disable and --disable-reason
disable_reason = 'disable_reason' disable_reason = 'disable_reason'

3
openstackclient/tests/functional/volume/v2/test_service.py
View File

@ -64,8 +64,7 @@ class VolumeServiceTests(common.BaseVolumeTests):
'enabled', 'enabled',
cmd_output[0]['Status'] cmd_output[0]['Status']
) )
self.assertEqual( self.assertIsNone(
None,
cmd_output[0]['Disabled Reason'] cmd_output[0]['Disabled Reason']
) )

2
tox.ini
View File

@ -85,6 +85,8 @@ commands = sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasen
[flake8] [flake8]
show-source = True show-source = True
# H203: Use assertIs(Not)None to check for None
enable-extensions = H203
exclude = .git,.tox,dist,doc,*lib/python*,*egg,build,tools exclude = .git,.tox,dist,doc,*lib/python*,*egg,build,tools
# If 'ignore' is not set there are default errors and warnings that are set # If 'ignore' is not set there are default errors and warnings that are set
# Doc: http://flake8.readthedocs.org/en/latest/config.html#default # Doc: http://flake8.readthedocs.org/en/latest/config.html#default