openstack/python-openstackclient
Code Issues Proposed changes

Merge "" openstack server image create " doesn't print proper info"

Browse Source
This commit is contained in:
Jenkins 2016-03-06 08:33:44 +00:00 committed by Gerrit Code Review
commit 67969e438c
1 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
openstackclient/compute/v2/server.py
View File

@ -161,6 +161,23 @@ def _prep_server_detail(compute_client, server):
return info return info
def _prep_image_detail(image_client, image_id):
"""Prepare the detailed image dict for printing
:param image_client: an image client instance
:param image_id: id of image created
:rtype: a dict of image details
"""
info = utils.find_resource(
image_client.images,
image_id,
)
# Glance client V2 doesn't have _info attribute
# The following condition deals with it.
return getattr(info, "_info", info)
def _show_progress(progress): def _show_progress(progress):
if progress: if progress:
sys.stdout.write('\rProgress: %s' % progress) sys.stdout.write('\rProgress: %s' % progress)
@ -622,12 +639,9 @@ class CreateServerImage(command.ShowOne):
sys.stdout.write(_('\nError creating server snapshot')) sys.stdout.write(_('\nError creating server snapshot'))
raise SystemExit raise SystemExit
image = utils.find_resource( image = _prep_image_detail(image_client, image_id)
image_client.images,
image_id,
)
return zip(*sorted(six.iteritems(image._info))) return zip(*sorted(six.iteritems(image)))
class DeleteServer(command.Command): class DeleteServer(command.Command):