openstack/puppet-zaqar
Code Issues Proposed changes

[trustee] password should be secret

Browse Source 
Change-Id: I8a29944a53171db1d17eb598f4a16c58c71febad
This commit is contained in:
Takashi Kajinami 2021-11-29 22:06:43 +09:00
parent 5bae33de89
commit 6052dfd0ff
2 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
manifests/keystone/trust.pp
View File

@ -40,12 +40,12 @@ class zaqar::keystone::trust(
include zaqar::deps
zaqar_config {
'trustee/username': value => $username;
'trustee/password': value => $password;
'trustee/username': value => $username;
'trustee/password': value => $password, secret =>true;
'trustee/user_domain_name': value => $user_domain_name;
'trustee/auth_url': value => $auth_url;
'trustee/auth_section': value => $auth_section;
'trustee/auth_type': value => $auth_type;
'trustee/auth_url': value => $auth_url;
'trustee/auth_section': value => $auth_section;
'trustee/auth_type': value => $auth_type;
}
}

14
spec/classes/zaqar_keystone_trust_spec.rb
View File

@ -6,18 +6,18 @@ describe 'zaqar::keystone::trust' do
describe 'with custom values' do
let :params do
{
:username => 'user',
:password => 'secret',
:auth_url => 'http://there',
:user_domain_name => 'domain',
:auth_section => 'keystone',
:auth_type => 'token',
:username => 'user',
:password => 'secret',
:auth_url => 'http://there',
:user_domain_name => 'domain',
:auth_section => 'keystone',
:auth_type => 'token',
}
end
it 'configures custom values' do
is_expected.to contain_zaqar_config('trustee/username').with_value('user')
is_expected.to contain_zaqar_config('trustee/password').with_value('secret')
is_expected.to contain_zaqar_config('trustee/password').with_value('secret').with_secret(true)
is_expected.to contain_zaqar_config('trustee/auth_url').with_value('http://there')
is_expected.to contain_zaqar_config('trustee/user_domain_name').with_value('domain')
is_expected.to contain_zaqar_config('trustee/auth_section').with_value('keystone')