Use validate_legacy

This changes all the puppet 3 validate_* functions
to use the validate_legacy function.

The validate_legacy function has been available since
about three years but require Puppet >= 4.4.0 and since
there is Puppet 4.10.12 as latest we should assume people
are running a fairly new Puppet 4 version.

This is the first step to then remove all validate function
calls and use proper types for parameter as described in spec [1].

[1] https://review.openstack.org/#/c/568929/

Change-Id: Ib31134bb604e32fd274b41dc78c4356500f71ab0

manifests/config.pp

@@ -26,7 +26,7 @@ class zaqar::config (
 
   include ::zaqar::deps
 
-  validate_hash($zaqar_config)
+  validate_legacy(Hash, 'validate_hash', $zaqar_config)
 
   create_resources('zaqar_config', $zaqar_config)
 }

manifests/db/mysql.pp

@@ -45,7 +45,7 @@ class zaqar::db::mysql(
 
   include ::zaqar::deps
 
-  validate_string($password)
+  validate_legacy(String, 'validate_string', $password)
 
   ::openstacklib::db::mysql { 'zaqar':
     user          => $user,

manifests/keystone/auth.pp

@@ -88,7 +88,7 @@ class zaqar::keystone::auth(
 
   include ::zaqar::deps
 
-  validate_string($password)
+  validate_legacy(String, 'validate_string', $password)
 
   keystone::resource::service_identity { 'zaqar':
     configure_user      => $configure_user,

manifests/keystone/auth_websocket.pp

@@ -76,7 +76,7 @@ class zaqar::keystone::auth_websocket(
 
   include ::zaqar::deps
 
-  validate_string($password)
+  validate_legacy(String, 'validate_string', $password)
 
   keystone::resource::service_identity { 'zaqar-websocket':
     configure_user      => $configure_user,

manifests/policy.pp

@@ -31,7 +31,7 @@ class zaqar::policy (
   include ::zaqar::deps
   include ::zaqar::params
 
-  validate_hash($policies)
+  validate_legacy(Hash, 'validate_hash', $policies)
 
   Openstacklib::Policy::Base {
     file_path  => $policy_path,
@@ -42,5 +42,4 @@ class zaqar::policy (
   create_resources('openstacklib::policy::base', $policies)
 
   oslo::policy { 'zaqar_config': policy_file => $policy_path }
-
 }