diff --git a/spec/classes/watcher_init_spec.rb b/spec/classes/watcher_init_spec.rb index 831114c..86a4d2e 100644 --- a/spec/classes/watcher_init_spec.rb +++ b/spec/classes/watcher_init_spec.rb @@ -26,22 +26,49 @@ describe 'watcher' do it { is_expected.to contain_class('watcher::policy') } it { is_expected.to contain_class('watcher::deps') } - it 'configures rabbit' do - is_expected.to contain_watcher_config('oslo_messaging_rabbit/rabbit_login_method').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_rabbit/rabbit_retry_interval').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_rabbit/rabbit_retry_backoff').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_rabbit/rabbit_interval_max').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_rabbit/rabbit_transient_queues_ttl').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_rabbit/heartbeat_timeout_threshold').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_rabbit/heartbeat_rate').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_rabbit/heartbeat_in_pthread').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_rabbit/kombu_compression').with_value('') - is_expected.to contain_watcher_config('DEFAULT/transport_url').with_value('') - is_expected.to contain_watcher_config('DEFAULT/rpc_response_timeout').with_value('') - is_expected.to contain_watcher_config('DEFAULT/control_exchange').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_notifications/transport_url').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_notifications/driver').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_notifications/topics').with_value('') + it 'configures messaging' do + is_expected.to contain_oslo__messaging__default('watcher_config').with( + :transport_url => '', + :rpc_response_timeout => '', + :control_exchange => '' + ) + is_expected.to contain_oslo__messaging__rabbit('watcher_config').with( + :rabbit_use_ssl => '', + :heartbeat_timeout_threshold => '', + :heartbeat_rate => '', + :heartbeat_in_pthread => '', + :kombu_reconnect_delay => '', + :kombu_failover_strategy => '', + :amqp_durable_queues => '', + :kombu_compression => '', + :kombu_ssl_ca_certs => '', + :kombu_ssl_certfile => '', + :kombu_ssl_keyfile => '', + :kombu_ssl_version => '', + :rabbit_ha_queues => '', + :rabbit_retry_interval => '', + ) + is_expected.to contain_oslo__messaging__amqp('watcher_config').with( + :server_request_prefix => '', + :broadcast_prefix => '', + :group_request_prefix => '', + :container_name => '', + :idle_timeout => '', + :trace => '', + :ssl_ca_file => '', + :ssl_cert_file => '', + :ssl_key_file => '', + :sasl_mechanisms => '', + :sasl_config_dir => '', + :sasl_config_name => '', + :username => '', + :password => '', + ) + is_expected.to contain_oslo__messaging__notifications('watcher_config').with( + :transport_url => '', + :driver => '', + :topics => '' + ) end it 'passes purge to resource' do @@ -56,78 +83,66 @@ describe 'watcher' do let :params do { :default_transport_url => 'rabbit://rabbit_user:password@localhost:5673', - :rabbit_ha_queues => 'undef', + :rpc_response_timeout => '120', + :control_exchange => 'watcher', + :rabbit_ha_queues => 'true', :rabbit_heartbeat_timeout_threshold => '60', :rabbit_heartbeat_rate => '10', :rabbit_heartbeat_in_pthread => true, + :amqp_durable_queues => true, :kombu_compression => 'gzip', + :kombu_failover_strategy => 'shuffle', + :kombu_reconnect_delay => '5.0', :notification_transport_url => 'rabbit://rabbit_user:password@localhost:5673', + :notification_driver => 'messaging', :notification_topics => 'notifications', - :package_ensure => '2012.1.1-15.el6', } end - it 'configures rabbit' do - is_expected.to contain_watcher_config('DEFAULT/transport_url').with_value('rabbit://rabbit_user:password@localhost:5673') - is_expected.to contain_watcher_config('oslo_messaging_rabbit/heartbeat_timeout_threshold').with_value('60') - is_expected.to contain_watcher_config('oslo_messaging_rabbit/heartbeat_rate').with_value('10') - is_expected.to contain_watcher_config('oslo_messaging_rabbit/heartbeat_in_pthread').with_value(true) - is_expected.to contain_watcher_config('oslo_messaging_rabbit/rabbit_login_method').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_rabbit/rabbit_retry_interval').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_rabbit/rabbit_retry_backoff').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_rabbit/rabbit_interval_max').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_rabbit/rabbit_transient_queues_ttl').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_rabbit/kombu_compression').with_value('gzip') - end - - it 'configures various things' do - is_expected.to contain_watcher_config('oslo_messaging_notifications/transport_url').with_value('rabbit://rabbit_user:password@localhost:5673') - is_expected.to contain_watcher_config('oslo_messaging_notifications/topics').with_value('notifications') - end - - end - - context 'with kombu_reconnect_delay set to 5.0' do - let :params do - { :kombu_reconnect_delay => '5.0' } - end - - it 'configures rabbit' do - is_expected.to contain_watcher_config('oslo_messaging_rabbit/kombu_reconnect_delay').with_value('5.0') - end - end - - context 'with rabbit_ha_queues set to true' do - let :params do - { :rabbit_ha_queues => 'true' } - end - - it 'configures rabbit' do - is_expected.to contain_watcher_config('oslo_messaging_rabbit/rabbit_ha_queues').with_value(true) - end - end - - context 'with rabbit_ha_queues set to false' do - let :params do - { :rabbit_ha_queues => 'false' } - end - - it 'configures rabbit' do - is_expected.to contain_watcher_config('oslo_messaging_rabbit/rabbit_ha_queues').with_value(false) - end - end - - context 'with amqp_durable_queues parameter' do - let :params do - { :amqp_durable_queues => 'true' } - end - - it 'configures rabbit' do - is_expected.to contain_watcher_config('oslo_messaging_rabbit/rabbit_ha_queues').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_rabbit/amqp_durable_queues').with_value(true) + it 'configures messaging' do + is_expected.to contain_oslo__messaging__default('watcher_config').with( + :transport_url => 'rabbit://rabbit_user:password@localhost:5673', + :rpc_response_timeout => '120', + :control_exchange => 'watcher' + ) is_expected.to contain_oslo__messaging__rabbit('watcher_config').with( - :rabbit_use_ssl => '', + :rabbit_use_ssl => '', + :heartbeat_timeout_threshold => '60', + :heartbeat_rate => '10', + :heartbeat_in_pthread => true, + :kombu_reconnect_delay => '5.0', + :kombu_failover_strategy => 'shuffle', + :amqp_durable_queues => true, + :kombu_compression => 'gzip', + :kombu_ssl_ca_certs => '', + :kombu_ssl_certfile => '', + :kombu_ssl_keyfile => '', + :kombu_ssl_version => '', + :rabbit_ha_queues => true, + :rabbit_retry_interval => '', + ) + is_expected.to contain_oslo__messaging__amqp('watcher_config').with( + :server_request_prefix => '', + :broadcast_prefix => '', + :group_request_prefix => '', + :container_name => '', + :idle_timeout => '', + :trace => '', + :ssl_ca_file => '', + :ssl_cert_file => '', + :ssl_key_file => '', + :sasl_mechanisms => '', + :sasl_config_dir => '', + :sasl_config_name => '', + :username => '', + :password => '', + ) + is_expected.to contain_oslo__messaging__notifications('watcher_config').with( + :transport_url => 'rabbit://rabbit_user:password@localhost:5673', + :driver => 'messaging', + :topics => 'notifications' ) end + end context 'with rabbit ssl enabled with kombu' do @@ -166,33 +181,6 @@ describe 'watcher' do end end - context 'with amqp overrides' do - let :params do - { :default_transport_url => 'amqp://amqp_user:password@localhost:5672', } - end - - context 'with default parameters' do - it 'configures amqp' do - is_expected.to contain_watcher_config('DEFAULT/transport_url').with_value('amqp://amqp_user:password@localhost:5672') - is_expected.to contain_watcher_config('oslo_messaging_amqp/server_request_prefix').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_amqp/broadcast_prefix').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_amqp/group_request_prefix').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_amqp/container_name').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_amqp/idle_timeout').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_amqp/trace').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_amqp/ssl_ca_file').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_amqp/ssl_cert_file').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_amqp/ssl_key_file').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_amqp/ssl_key_password').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_amqp/sasl_mechanisms').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_amqp/sasl_config_dir').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_amqp/sasl_config_name').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_amqp/username').with_value('') - is_expected.to contain_watcher_config('oslo_messaging_amqp/password').with_value('') - end - end - end - context 'with overridden amqp parameters' do let :params do { :default_transport_url => 'amqp://amqp_user:password@localhost:5672', @@ -207,14 +195,25 @@ describe 'watcher' do end it 'configures amqp' do - is_expected.to contain_watcher_config('DEFAULT/transport_url').with_value('amqp://amqp_user:password@localhost:5672') - is_expected.to contain_watcher_config('oslo_messaging_amqp/idle_timeout').with_value('60') - is_expected.to contain_watcher_config('oslo_messaging_amqp/trace').with_value('true') - is_expected.to contain_watcher_config('oslo_messaging_amqp/ssl_ca_file').with_value('/etc/ca.cert') - is_expected.to contain_watcher_config('oslo_messaging_amqp/ssl_cert_file').with_value('/etc/certfile') - is_expected.to contain_watcher_config('oslo_messaging_amqp/ssl_key_file').with_value('/etc/key') - is_expected.to contain_watcher_config('oslo_messaging_amqp/username').with_value('amqp_user') - is_expected.to contain_watcher_config('oslo_messaging_amqp/password').with_value('password') + is_expected.to contain_oslo__messaging__default('watcher_config').with( + :transport_url => 'amqp://amqp_user:password@localhost:5672', + ) + is_expected.to contain_oslo__messaging__amqp('watcher_config').with( + :server_request_prefix => '', + :broadcast_prefix => '', + :group_request_prefix => '', + :container_name => '', + :idle_timeout => '60', + :trace => true, + :ssl_ca_file => '/etc/ca.cert', + :ssl_cert_file => '/etc/certfile', + :ssl_key_file => '/etc/key', + :sasl_mechanisms => '', + :sasl_config_dir => '', + :sasl_config_name => '', + :username => 'amqp_user', + :password => 'password', + ) end end end