openstack/puppet-openstack-integration
Code Issues Proposed changes

Fix bug and non-idiom in bash scripts.

Browse Source 
Those small typos and non-idiom can lead to unexpected behavior, better
fix them now.

Change-Id: I218ba0f3bba832d0929fb52c21f7e66774da494e
Closes-Bug: #1561539
This commit is contained in:
Sofer Athlan-Guyot 2016-03-24 14:39:05 +01:00
parent cf864be1bc
commit 53eb3a966d
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
install_modules.sh
View File

@ -2,11 +2,11 @@
set -ex set -ex
if [ ! -z ${GEM_HOME} ]; then if [ -n "${GEM_HOME}" ]; then
GEM_BIN_DIR=${GEM_HOME}/bin/ GEM_BIN_DIR=${GEM_HOME}/bin/
fi fi
if [ $PUPPET_VERSION == 4 ]; then if [ "${PUPPET_VERSION}" = 4 ]; then
export PUPPET_BASE_PATH=/etc/puppetlabs/code export PUPPET_BASE_PATH=/etc/puppetlabs/code
else else
export PUPPET_BASE_PATH=/etc/puppet export PUPPET_BASE_PATH=/etc/puppet

4
install_modules_unit.sh
View File

@ -6,11 +6,11 @@
set -ex set -ex
if [ ! -z ${GEM_HOME} ]; then if [ -n "${GEM_HOME}" ]; then
GEM_BIN_DIR=${GEM_HOME}/bin/ GEM_BIN_DIR=${GEM_HOME}/bin/
fi fi
if [ $PUPPET_VERSION == 4 ]; then if [ "${PUPPET_VERSION}" = 4 ]; then
export PUPPET_BASE_PATH=/etc/puppetlabs/code export PUPPET_BASE_PATH=/etc/puppetlabs/code
else else
export PUPPET_BASE_PATH=/etc/puppet export PUPPET_BASE_PATH=/etc/puppet