openstack/puppet-openstack-integration
Code Issues Proposed changes

Fix lint jobs not reporting error

Browse Source 
Test moving out the actual run of the
commands from bundler to see if it's
that causing it to still have ret code 0
when having errors.

Change-Id: I030afe7bda996a3040c073193f0b0999ce973468
This commit is contained in:
Tobias Urdin 2018-12-13 14:18:30 +01:00
parent 8e0002d3bf
commit 0ab0a819f7
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
playbooks/run-lint-tests.yaml
View File

@ -2,6 +2,7 @@
tasks: tasks:
- shell: - shell:
cmd: | cmd: |
set -e
if [ -f Modulefile -o -f metadata.json ]; then if [ -f Modulefile -o -f metadata.json ]; then
if [ -f Modulefile ]; then if [ -f Modulefile ]; then
MODULE=$(awk '/^name/ {print $NF}' Modulefile |tr -d \"\') MODULE=$(awk '/^name/ {print $NF}' Modulefile |tr -d \"\')
@ -26,10 +27,11 @@
$GEM_HOME/bin/bundle exec rake metadata_lint 2>&1 $GEM_HOME/bin/bundle exec rake metadata_lint 2>&1
fi fi
else else
gem install rake -n ./.bundled_gems/ gem install rake -n ./.bundled_gems/ --no-ri --no-rdoc
gem install puppet-lint gem install puppet-lint -n ./.bundled_gems/ --no-ri --no-rdoc
gem install metadata-json-lint -n ./.bundled_gems/ --no-ri --no-rdoc gem install metadata-json-lint -n ./.bundled_gems/ --no-ri --no-rdoc
gem install puppetlabs_spec_helper gem install puppetlabs_spec_helper -n ./.bundled_gems/ --no-ri --no-rdoc
gem install puppet -n ./.bundled_gems/ --no-ri --no-rdoc
./.bundled_gems/rake lint 2>&1 ./.bundled_gems/rake lint 2>&1
if [ -f metadata.json ]; then if [ -f metadata.json ]; then
./.bundled_gems/metadata-json-lint ./.bundled_gems/metadata-json-lint