Update cookiecutter to use puppet-oslo module

Update logging, db and policy classes to use oslo defines.

Change-Id: Iae438c3d80044ed25faf0a3424fe3edefc1e6336
This commit is contained in:
iberezovskiy 2016-04-12 14:42:02 +03:00
parent ef2a41ea42
commit fe8df61f24
5 changed files with 32 additions and 70 deletions

View File

@ -43,8 +43,6 @@ class {{cookiecutter.project_name}}::db (
$database_max_overflow = $::os_service_default,
) {
include ::{{cookiecutter.project_name}}::params
$database_connection_real = pick($::{{cookiecutter.project_name}}::database_connection, $database_connection)
$database_idle_timeout_real = pick($::{{cookiecutter.project_name}}::database_idle_timeout, $database_idle_timeout)
$database_min_pool_size_real = pick($::{{cookiecutter.project_name}}::database_min_pool_size, $database_min_pool_size)
@ -56,44 +54,13 @@ class {{cookiecutter.project_name}}::db (
validate_re($database_connection_real,
'^(sqlite|mysql(\+pymysql)?|postgresql):\/\/(\S+:\S+@\S+\/\S+)?')
case $database_connection_real {
/^mysql(\+pymysql)?:\/\//: {
require 'mysql::bindings'
require 'mysql::bindings::python'
if $database_connection_real =~ /^mysql\+pymysql/ {
$backend_package = $::{{cookiecutter.project_name}}::params::pymysql_package_name
} else {
$backend_package = false
}
}
/^postgresql:\/\//: {
$backend_package = false
require 'postgresql::lib::python'
}
/^sqlite:\/\//: {
$backend_package = $::{{cookiecutter.project_name}}::params::sqlite_package_name
}
default: {
fail('Unsupported backend configured')
}
oslo::db { '{{cookiecutter.project_name}}_config':
connection => $database_connection_real,
idle_timeout => $database_idle_timeout_real,
min_pool_size => $database_min_pool_size_real,
max_retries => $database_max_retries_real,
retry_interval => $database_retry_interval_real,
max_pool_size => $database_max_pool_size_real,
max_overflow => $database_max_overflow_real,
}
if $backend_package and !defined(Package[$backend_package]) {
package {'{{cookiecutter.project_name}}-backend-package':
ensure => present,
name => $backend_package,
tag => 'openstack',
}
}
{{cookiecutter.project_name}}_config {
'database/connection': value => $database_connection_real, secret => true;
'database/idle_timeout': value => $database_idle_timeout_real;
'database/min_pool_size': value => $database_min_pool_size_real;
'database/max_retries': value => $database_max_retries_real;
'database/retry_interval': value => $database_retry_interval_real;
'database/max_pool_size': value => $database_max_pool_size_real;
'database/max_overflow': value => $database_max_overflow_real;
}
}

View File

@ -118,31 +118,23 @@ class {{cookiecutter.project_name}}::logging(
$log_date_format = $::os_service_default,
) {
if is_service_default($default_log_levels) {
$default_log_levels_real = $default_log_levels
} else {
$default_log_levels_real = join(sort(join_keys_to_values($default_log_levels, '=')), ',')
oslo::log { '{{cookiecutter.project_name}}_config':
use_stderr => $use_stderr,
use_syslog => $use_syslog,
log_dir => $log_dir,
log_file => $log_file,
debug => $debug,
verbose => $verbose,
logging_context_format_string => $logging_context_format_string,
logging_default_format_string => $logging_default_format_string,
logging_debug_format_suffix => $logging_debug_format_suffix,
logging_exception_prefix => $logging_exception_prefix,
log_config_append => $log_config_append,
default_log_levels => $default_log_levels,
publish_errors => $publish_errors,
fatal_deprecations => $fatal_deprecations,
instance_format => $instance_format,
instance_uuid_format => $instance_uuid_format,
log_date_format => $log_date_format,
}
{{cookiecutter.project_name}}_config {
'DEFAULT/use_syslog' : value => $use_syslog;
'DEFAULT/use_stderr' : value => $use_stderr;
'DEFAULT/syslog_log_facility' : value => $log_facility;
'DEFAULT/log_dir' : value => $log_dir;
'DEFAULT/log_file': value => $log_file;
'DEFAULT/verbose' : value => $verbose;
'DEFAULT/debug' : value => $debug;
'DEFAULT/default_log_levels' : value => $default_log_levels_real;
'DEFAULT/logging_context_format_string' : value => $logging_context_format_string;
'DEFAULT/logging_default_format_string' : value => $logging_default_format_string;
'DEFAULT/logging_debug_format_suffix' : value => $logging_debug_format_suffix;
'DEFAULT/logging_exception_prefix' : value => $logging_exception_prefix;
'DEFAULT/log_config_append' : value => $log_config_append;
'DEFAULT/publish_errors' : value => $publish_errors;
'DEFAULT/fatal_deprecations' : value => $fatal_deprecations;
'DEFAULT/instance_format' : value => $instance_format;
'DEFAULT/instance_uuid_format' : value => $instance_uuid_format;
'DEFAULT/log_date_format' : value => $log_date_format;
}
}

View File

@ -36,4 +36,6 @@ class {{cookiecutter.project_name}}::policy (
create_resources('openstacklib::policy::base', $policies)
oslo::policy { '{{cookiecutter.project_name}}_config': policy_file => $policy_path }
}

View File

@ -29,6 +29,7 @@
"dependencies": [
{ "name": "puppetlabs/inifile", "version_requirement": ">=1.0.0 <2.0.0" },
{ "name": "puppetlabs/stdlib", "version_requirement": ">= 4.2.0 <5.0.0" },
{ "name": "openstack/openstacklib", "version_requirement": ">=7.0.0 <8.0.0" }
{ "name": "openstack/openstacklib", "version_requirement": ">=7.0.0 <8.0.0" },
{ "name": "openstack/oslo", "version_requirement": "<9.0.0" }
]
}

View File

@ -88,7 +88,7 @@ describe '{{cookiecutter.project_name}}::db' do
end
it 'install the proper backend package' do
is_expected.to contain_package('{{cookiecutter.project_name}}-backend-package').with(
is_expected.to contain_package('db_backend_package').with(
:ensure => 'present',
:name => 'python-pymysql',
:tag => 'openstack'
@ -113,7 +113,7 @@ describe '{{cookiecutter.project_name}}::db' do
end
it 'install the proper backend package' do
is_expected.not_to contain_package('{{cookiecutter.project_name}}-backend-package')
is_expected.not_to contain_package('db_backend_package')
end
end
end