openstack/puppet-openstack-cookiecutter
Code Issues Proposed changes

Do not validate database_connection format

Browse Source 
Currently we validate database_connection in 2 layers, each puppet
modules and puppet-oslo, however this makes it difficult to maintain
validation pattern because we always need to fix both.
This patch removes the validation from each puppet modules so that
we need to maitain only one place, puppet-oslo to update validation
logic.

Change-Id: I6a09b427b720d6bc28e3e9c5130a0e9b26639f98
This commit is contained in:
Takashi Kajinami 2020-08-31 17:55:24 +09:00
parent 3c568a622e
commit f9bcdf4fcb
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
puppet-{{cookiecutter.project_name}}/manifests/db.pp
View File

@ -51,9 +51,6 @@ class {{cookiecutter.project_name}}::db (
include {{cookiecutter.project_name}}::deps
validate_legacy(Oslo::Dbconn, 'validate_re', $database_connection,
['^(sqlite|mysql(\+pymysql)?|postgresql):\/\/(\S+:\S+@\S+\/\S+)?'])
oslo::db { '{{cookiecutter.project_name}}_config':
connection => $database_connection,
connection_recycle_time => $database_connection_recycle_time,