openstack/openstack-ansible-tests
Code Issues Proposed changes

test-prepare-host: SUSE: Fix escaping of double quotes

Browse Source 
Escaping the double quotes only makes sense when the entire string
is surrounded by double quotes otherwise invalid entries are being
written to ifcfg files.

POST_UP_SCRIPT=\"compat:suse:ifup-post-veth-br-vlan-2-eth12\"

Change-Id: If97950d360a133a3f8875f29344ccfdb914d7bf5
This commit is contained in:
Markos Chandras 2017-07-17 12:04:26 +01:00
parent d75bd8349c
commit b29e4c523c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test-prepare-host.yml
View File

@ -123,14 +123,14 @@
- name: Configure ifcfg files to use the post-up script (SUSE) - name: Configure ifcfg files to use the post-up script (SUSE)
lineinfile: lineinfile:
dest: "/etc/sysconfig/network/ifcfg-{{ item[1].name | default('br-mgmt') }}" dest: "/etc/sysconfig/network/ifcfg-{{ item[1].name | default('br-mgmt') }}"
line: POST_UP_SCRIPT=\"compat:suse:{{ item[0] }}-veth-{{ item[1].name | default('br-mgmt') }}-2-{{ item[1].veth_peer | default('eth1') }}\" line: "POST_UP_SCRIPT=\"compat:suse:{{ item[0] }}-veth-{{ item[1].name | default('br-mgmt') }}-2-{{ item[1].veth_peer | default('eth1') }}\""
with_nested: with_nested:
- [ "ifup-post", "ifdown-post" ] - [ "ifup-post", "ifdown-post" ]
- "{{ bridges }}" - "{{ bridges }}"
- name: Configure ifcfg files to use the post-down script (SUSE) - name: Configure ifcfg files to use the post-down script (SUSE)
lineinfile: lineinfile:
dest: "/etc/sysconfig/network/ifcfg-{{ item[1].name | default('br-mgmt') }}" dest: "/etc/sysconfig/network/ifcfg-{{ item[1].name | default('br-mgmt') }}"
line: POST_DOWN_SCRIPTS=\"compat:suse:{{ item[0] }}-veth-{{ item[1].name | default('br-mgmt') }}-2-{{ item[1].veth_peer | default('eth1') }}\" line: "POST_DOWN_SCRIPTS=\"compat:suse:{{ item[0] }}-veth-{{ item[1].name | default('br-mgmt') }}-2-{{ item[1].veth_peer | default('eth1') }}\""
with_nested: with_nested:
- [ "ifup-post", "ifdown-post" ] - [ "ifup-post", "ifdown-post" ]
- "{{ bridges }}" - "{{ bridges }}"