openstack/openstack-ansible-os_trove
Code Issues Proposed changes

Replace virtualenv-tools by a script

Browse Source 
virtualenv-tools has a bug which gets triggered in gates: it can't
change the shebang of a virtualenv python bin/ files if they
were generated with a virtualenv script whose shebang ends with
python2 instead of python.

Because we can't modify virtualenv-tools, we use shell scripts
instead.

Change-Id: Iad3a44f35c57d92dcbbfde4acbd86a3a4eb1879d
Partial-Bug: #1741634
This commit is contained in:
Jean-Philippe Evrard 2018-01-15 13:54:00 +00:00 committed by Mohammed Naser
parent 76fea25f33
commit 2b51da5f0a
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
defaults/main.yml
View File

@ -196,7 +196,6 @@ trove_requires_pip_packages:
- python-glanceclient - python-glanceclient
- python-keystoneclient - python-keystoneclient
- virtualenv - virtualenv
- virtualenv-tools
- shade - shade
- futures - futures

8
tasks/trove_install.yml
View File

@ -122,9 +122,13 @@
- trove_get_venv | changed - trove_get_venv | changed
- name: Update virtualenv path - name: Update virtualenv path
command: > shell: |
virtualenv-tools --update-path=auto --reinitialize {{ trove_bin | dirname }} find {{ trove_bin }} -name \*.pyc -delete
sed -si '1s/^.*python.*$/#!{{ trove_bin | replace ('/','\/') }}\/python/' {{ trove_bin }}/*
virtualenv {{ trove_bin | dirname }}
when: trove_get_venv | changed when: trove_get_venv | changed
tags:
- skip_ansible_lint
- name: Record the venv tag deployed - name: Record the venv tag deployed
ini_file: ini_file: