openstack/openstack-ansible-os_swift
Code Issues Proposed changes
openstack-ansible-os_swift/tasks/swift_install.yml
Matt Thompson 94b72365ac Re-deploy the Swift venv if it mismatches the repo 
We currently have two issues with venvs:

- if you update your venv on the repo server, it is not possible for
  that updated venv to land on the service's container as the get_url
  task always skips if the file exists (even if the file is different)
- if you have an updated venv on the repo server and forcefully delete
  the cached venv tarball on the service's container, the new tarball
  will get unarchived over top of the existing venv

This commit does the following:

- gets the checksum of the /var/cache tarball and downloads checksum
  file from repo server
- updates "Attempt venv download" to only download the venv if the
  cache doesn't exist or if the local and remote checksums differ
- adds a "force: true" to "Attempt venv download" task so that the venv
  tarball will get re-downloaded when the when condition is true (this
  is necessary otherwise the download will get skipped since the
  destination already exists)
- adds a new task "Remove existing venv" so we can first remove the
  venv before we unarchive the potentially new venv from the repo
  server
- updates "Create swift venv dir" and "Unarchive pre-built venv"
  tasks to only proceed if "swift_get_venv | changed", which
  prevents these tasks from running when they the venv tarball hasn't
  changed
- adds multiple service restarts to
  os_swift/tasks/swift_install.yml so that swift will restart
  correctly should the venv/packages update without any associated
  config changes

NOTE: The reason why we compare local and remote checksum is to avoid
      unnecessarily downloading the venv when the checksums are in fact
      the same.  On small deploys this is more or less a non-issue but
      if a deploy w/ thousands of compute nodes re-runs playbooks we
      want to limit the venv downloads when it's unnecessary.

Change-Id: I4b028f6e4ca59eceac010d2bbc10a8d79f6f3937
2016-01-28 09:11:56 +00:00

197 lines
5.0 KiB
YAML
Raw Blame History

---
# Copyright 2014, Rackspace US, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
- name: Update apt sources
apt:
update_cache: yes
cache_valid_time: 600
register: apt_update
until: apt_update|success
retries: 5
delay: 2
tags:
- swift-apt-packages
- name: Install apt packages
apt:
pkg: "{{ item }}"
state: latest
register: install_packages
until: install_packages|success
retries: 5
delay: 2
with_items: swift_apt_packages
tags:
- swift-install
- swift-apt-packages
- name: Install requires pip packages
pip:
name: "{{ item }}"
state: present
extra_args: "{{ pip_install_options|default('') }}"
register: install_packages
until: install_packages|success
retries: 5
delay: 2
with_items:
- "{{ swift_requires_pip_packages }}"
tags:
- swift-install
- swift-pip-packages
- name: Get local venv checksum
stat:
path: "/var/cache/{{ swift_venv_download_url | basename }}"
get_md5: False
when: swift_venv_enabled | bool
register: local_venv_stat
tags:
- swift-install
- swift-pip-packages
- name: Get remote venv checksum
uri:
url: "{{ swift_venv_download_url | replace('tgz', 'checksum') }}"
return_content: True
when: swift_venv_enabled | bool
register: remote_venv_checksum
tags:
- swift-install
- swift-pip-packages
# TODO: When project moves to ansible 2 we can pass this a sha256sum which will:
# a) allow us to remove force: yes
# b) allow the module to calculate the checksum of dest file which would
# result in file being downloaded only if provided and dest sha256sum
# checksums differ
- name: Attempt venv download
get_url:
url: "{{ swift_venv_download_url }}"
dest: "/var/cache/{{ swift_venv_download_url | basename }}"
force: yes
ignore_errors: true
register: get_venv
when:
- swift_venv_enabled | bool
- (local_venv_stat.stat.exists == False or
{{ local_venv_stat.stat.checksum is defined and local_venv_stat.stat.checksum != remote_venv_checksum.content | trim }})
tags:
- swift-install
- swift-pip-packages
- name: Set swift get_venv fact
set_fact:
swift_get_venv: "{{ get_venv }}"
when: swift_venv_enabled | bool
tags:
- swift-install
- swift-pip-packages
- name: Remove existing venv
file:
path: "{{ swift_venv_bin | dirname }}"
state: absent
when:
- swift_venv_enabled | bool
- swift_get_venv | changed
tags:
- swift-install
- swift-pip-packages
- name: Create swift venv dir
file:
path: "{{ swift_venv_bin | dirname }}"
state: directory
when:
- swift_venv_enabled | bool
- swift_get_venv | changed
tags:
- swift-install
- swift-pip-packages
- name: Unarchive pre-built venv
unarchive:
src: "/var/cache/{{ swift_venv_download_url | basename }}"
dest: "{{ swift_venv_bin | dirname }}"
copy: "no"
when:
- swift_venv_enabled | bool
- swift_get_venv | changed
notify:
- Restart swift account services
- Restart swift container services
- Restart swift object services
- Restart swift proxy services
tags:
- swift-install
- swift-pip-packages
- name: Update virtualenv path
command: >
virtualenv-tools --update-path=auto {{ swift_venv_bin | dirname }}
when:
- swift_venv_enabled | bool
- swift_get_venv | success
tags:
- swift-install
- swift-pip-packages
- name: Install pip packages (venv)
pip:
name: "{{ item }}"
state: present
virtualenv: "{{ swift_venv_bin | dirname }}"
virtualenv_site_packages: "no"
extra_args: "{{ pip_install_options|default('') }}"
register: install_packages
until: install_packages|success
retries: 5
delay: 2
with_items:
- "{{ swift_pip_packages }}"
when:
- swift_venv_enabled | bool
- swift_get_venv | failed
notify:
- Restart swift account services
- Restart swift container services
- Restart swift object services
- Restart swift proxy services
tags:
- swift-install
- swift-pip-packages
- name: Install pip packages (no venv)
pip:
name: "{{ item }}"
state: present
extra_args: "{{ pip_install_options|default('') }}"
register: install_packages
until: install_packages|success
retries: 5
delay: 2
with_items:
- "{{ swift_pip_packages }}"
when: not swift_venv_enabled | bool
notify:
- Restart swift account services
- Restart swift container services
- Restart swift object services
- Restart swift proxy services
tags:
- swift-install
- swift-pip-packages
View Git Blame Copy Permalink