From e45107b4fd6e6ce42143c25e27a59e1afe958f19 Mon Sep 17 00:00:00 2001
From: Dmitriy Rabotyagov <dmitriy.rabotyagov@cleura.com>
Date: Mon, 9 Sep 2024 16:51:12 +0200
Subject: [PATCH] Improve OVN cluster setup idempotence report

Current command/shell modules for ovn cluster setup while fetching
current deployment state do not actually have changed_when: false
which causes these tasks to end up in "Changed" state

Change-Id: Id4b947d0b7aaa54eb3bbe58d2593ad6b49009b5c
---
 tasks/providers/ovn_cluster_setup.yml | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tasks/providers/ovn_cluster_setup.yml b/tasks/providers/ovn_cluster_setup.yml
index 1e84281f..d39b44c4 100644
--- a/tasks/providers/ovn_cluster_setup.yml
+++ b/tasks/providers/ovn_cluster_setup.yml
@@ -20,9 +20,8 @@
   command: ovsdb-tool db-is-clustered /var/lib/ovn/ovnnb_db.db
   ignore_errors: true
   failed_when: false
+  changed_when: false
   register: _check_cluster_db
-  tags:
-    - skip_ansible_lint
 
 # We need to clean existing ovn db/lock file before cluster join.
 - name: Clean up db/lock files before creating ovn cluster
@@ -51,9 +50,8 @@
     loop_var: container
   run_once: true
   failed_when: false
+  changed_when: false
   register: _find_leader
-  tags:
-    - skip_ansible_lint
 
 # set leader_node variable
 - name: Set leader_node fact