Deprecate the deployment of the AT&T neutron HA tool

The AT&T neutron HA tool has been deprecated and will not be deployed
by default. It is no longer is the correct means to enable L3HA within
an OpenStack environment.

Change-Id: I3f9aeb554d153ef3aa1db9a1037c7d57a45968b0
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>

defaults/main.yml

@@ -229,6 +229,10 @@ neutron_lbaasv2: "{% if 'lbaasv2' in neutron_plugin_base or 'neutron_lbaas.servi
 #TODO(odyssey4me): Remove the class path from this conditional in the Newton cycle
 neutron_l3: "{% if 'router' in neutron_plugin_base or 'neutron.services.l3_router.l3_router_plugin.L3RouterPlugin' in neutron_plugin_base %}True{% else %}False{% endif %}"
 
+# Set this option to "true" to enable legacy neutron L3HA tool support
+# TODO(cloudnull): Remove this in the Ocata cycle
+neutron_legacy_ha_tool_enabled: false
+
 ## Neutron Metering
 # Please add 'metering' to the neutron_plugin_base list
 #TODO(odyssey4me): Remove the class path from this conditional in the Newton cycle

releasenotes/notes/removed-neutron-ha-tool-dd7a4717e03163f9.yaml

@@ -0,0 +1,13 @@
+---
+deprecations:
+  - The Neutron HA tool written by AT&T has been deprecated and will be
+    removed in the Ocata release.
+upgrade:
+  - The Neutron HA tool written by AT&T is no longer enabled by default.
+    This tool was providing HA capabilities for networks and routers
+    that were not using the native Neutron L3HA. Because native Neutron
+    L3HA is stable, compatible with the Linux Bridge Agent, and is
+    a better means of enabling HA within a deployment this tool is no
+    longer being setup by default. If legacy L3HA is needed within a
+    deployment the deployer can set `neutron_legacy_ha_tool_enabled` to
+    **true** to enable the legacy tooling.

tasks/main.yml

@@ -55,8 +55,9 @@
     inventory_hostname == groups['neutron_all'][0]
 
 - include: neutron_l3_ha.yml
-  when: >
-    inventory_hostname in groups[neutron_services['neutron-l3-agent']['group']]
+  when:
+    - inventory_hostname in groups[neutron_services['neutron-l3-agent']['group']]
+    - neutron_legacy_ha_tool_enabled | bool
 
 - name: Flush handlers
   meta: flush_handlers

tasks/neutron_l3_ha.yml

@@ -64,13 +64,3 @@
     cron_file: "neutron-ha-tool"
   tags:
     - neutron-ha-tool
-
-- name: Remove old cronjobs if found.
-  file:
-    path: "{{ item }}"
-    state: "absent"
-  with_items:
-    - /etc/cron.d/replicate_dhcp
-    - /etc/cron.d/l3_agent_migrate
-  tags:
-    - neutron-ha-tool