openstack/openstack-ansible-os_manila
Code Issues Proposed changes

developer_mode: drop vars

Browse Source 
The developer mode no longer exists, therefore, we should remove
all references and we're already installing the distro devel
packages inside python_venv_build.

We were also referencing the wrong constraint variable, so this
fixes that as well.

Change-Id: Iaf2e848b80923718741c148f2a76d5a3efca53b1
This commit is contained in:
Mohammed Naser 2019-03-28 20:59:46 -04:00
parent 651e084aa1
commit d37116a602
4 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
defaults/main.yml
View File

@ -31,7 +31,7 @@ manila_git_install_branch: master
manila_upper_constraints_url: "{{ requirements_git_url | default('https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h=' ~ requirements_git_install_branch | default('master')) }}"
manila_git_constraints:
- "git+{{ manila_git_repo }}@{{ manila_git_install_branch }}#egg=manila"
- "--constraint {{ barbican_upper_constraints_url }}"
- "--constraint {{ manila_upper_constraints_url }}"
manila_pip_install_args: "{{ pip_install_options | default('') }}"

1
tests/os_manila-overrides.yml
View File

@ -110,7 +110,6 @@ test_manila_share_group: "{{ ((groups['manila_share'] is defined) and (groups['m
test_manila_api_host: "{{ hostvars[groups[test_manila_api_group][0]]['ansible_host'] }}"
test_manila_share_host: "{{ hostvars[groups[test_manila_share_group][0]]['ansible_host'] }}"
manila_container_mysql_password: "SuperSecrete"
manila_developer_mode: true
manila_git_install_branch: "{{ test_branch }}"
manila_profiler_hmac_key: "secrete"
manila_oslomsg_rpc_password: "secrete"

3
vars/distro_install.yml
View File

@ -32,9 +32,6 @@ manila_package_list: |-
{% if manila_services['manila_scheduler']['group'] in group_names %}
{% set _ = packages.extend(manila_scheduler_distro_packages) %}
{% endif %}
{% if manila_developer_mode | bool %}
{% set _ = packages.extend(manila_devel_distro_packages) %}
{% endif %}
{% if manila_oslomsg_amqp1_enabled | bool %}
{% set _ = packages.extend(manila_oslomsg_amqp1_distro_packages) %}
{% endif %}

3
vars/source_install.yml
View File

@ -26,9 +26,6 @@ manila_package_list: |-
{% set _ = packages.extend(manila_lvm_share_distro_packages) %}
{% endif %}
{% endif %}
{% if manila_developer_mode | bool %}
{% set _ = packages.extend(manila_devel_distro_packages) %}
{% endif %}
{% if manila_oslomsg_amqp1_enabled | bool %}
{% set _ = packages.extend(manila_oslomsg_amqp1_distro_packages) %}
{% endif %}