Auto-fix yaml rules

In order to reduce divergance with ansible-lint rules, we apply
auto-fixing of violations.

In current patch we replace all kind of truthy variables with
`true` or `false` values to align with recommendations along with
alignment of used quotes.

Change-Id: I6bfe2a4bde3d4c5d8f3cac272ab5f7d2b9cfbcb0

.gitignore

@@ -48,6 +48,7 @@ logs/*
 .tox
 *.egg-info
 .eggs
+.ansible
 
 # Generated by pbr while building docs
 ######################################

defaults/main.yml

@@ -14,7 +14,7 @@
 # limitations under the License.
 
 ## Verbosity Options
-debug: False
+debug: false
 
 # Enable/Disable Ceilometer
 designate_ceilometer_enabled: "{{ (groups['ceilometer_all'] is defined) and (groups['ceilometer_all'] | length > 0) }}"
@@ -237,7 +237,6 @@ designate_mdns_init_overrides: {}
 designate_sink_init_overrides: {}
 designate_api_init_overrides: {}
 
-
 ## Service Name-Group Mapping
 designate_services:
   designate-central:
@@ -301,7 +300,7 @@ designate_pki_setup_host: "{{ openstack_pki_setup_host | default('localhost') }}
 designate_pki_keys_path: "{{ designate_pki_dir ~ '/certs/private/' }}"
 designate_pki_certs_path: "{{ designate_pki_dir ~ '/certs/certs/' }}"
 designate_pki_intermediate_cert_name: "{{ openstack_pki_service_intermediate_cert_name | default('ExampleCorpIntermediate') }}"
-designate_pki_regen_cert: ''
+designate_pki_regen_cert: ""
 designate_pki_san: "{{ openstack_pki_san | default('DNS:' ~ ansible_facts['hostname'] ~ ',IP:' ~ management_address) }}"
 designate_pki_certificates:
   - name: "designate_{{ ansible_facts['hostname'] }}"

handlers/main.yml

@@ -31,7 +31,7 @@
 
 - name: Perform Designate pools update
   command: "{{ designate_bin }}/designate-manage pool update --file /etc/designate/pools.yaml"
-  become: yes
+  become: true
   become_user: "{{ designate_system_user_name }}"
   changed_when: false
   when: designate_pools_yaml is defined

tasks/designate_db_sync.yml

@@ -15,6 +15,6 @@
 
 - name: Perform a Designate DB sync
   command: "{{ designate_bin }}/designate-manage database sync"
-  become: yes
+  become: true
   become_user: "{{ designate_system_user_name }}"
   changed_when: false

vars/distro_install.yml

@@ -15,12 +15,12 @@
 #
 
 designate_package_list: |-
-    {% set packages = designate_distro_packages %}
+  {% set packages = designate_distro_packages %}
-    {% set _ = packages.extend(designate_service_distro_packages) %}
+  {% set _ = packages.extend(designate_service_distro_packages) %}
-    {% if designate_rndc_keys is defined %}
+  {% if designate_rndc_keys is defined %}
-    {%   set _ = packages.extend(designate_rndc_packages) %}
+  {%   set _ = packages.extend(designate_rndc_packages) %}
-    {% endif %}
+  {% endif %}
-    {{ packages }}
+  {{ packages }}
 
 _designate_bin: "/usr/bin"
 _designate_etc: "/etc"

vars/source_install.yml

@@ -15,11 +15,11 @@
 #
 
 designate_package_list: |-
-    {% set packages = designate_distro_packages %}
+  {% set packages = designate_distro_packages %}
-    {% if designate_rndc_keys is defined %}
+  {% if designate_rndc_keys is defined %}
-    {%   set _ = packages.extend(designate_rndc_packages) %}
+  {%   set _ = packages.extend(designate_rndc_packages) %}
-    {% endif %}
+  {% endif %}
-    {{ packages }}
+  {{ packages }}
 
 _designate_bin: "/openstack/venvs/designate-{{ designate_venv_tag }}/bin"
 _designate_etc: "{{ _designate_bin | dirname + '/etc' }}"