Auto-fix usage of modules via FQCN

Since ansible-core 2.10 it is recommended to use modules via FQCN
In order to align with recommendation, we perform migration
by applying suggestions made by `ansible-lint --fix=fqcn`

Change-Id: I7a2d1093c8dad80e3156f17bdeb9303df957e2a6

handlers/main.yml

@@ -15,7 +15,7 @@
 # limitations under the License.
 
 - name: Stop services
-  systemd:
+  ansible.builtin.systemd:
     name: "{{ item.service_name }}"
     state: "stopped"
   with_items: "{{ filtered_designate_services }}"
@@ -30,14 +30,14 @@
     - "cert installed"
 
 - name: Perform Designate pools update
-  command: "{{ designate_bin }}/designate-manage pool update --file /etc/designate/pools.yaml"
+  ansible.builtin.command: "{{ designate_bin }}/designate-manage pool update --file /etc/designate/pools.yaml"
   become: true
   become_user: "{{ designate_system_user_name }}"
   changed_when: false
   when: designate_pools_yaml is defined
 
 - name: Start services
-  systemd:
+  ansible.builtin.systemd:
     name: "{{ item.service_name }}"
     state: "started"
   with_items: "{{ filtered_designate_services }}"

tasks/designate_db_sync.yml

@@ -14,7 +14,7 @@
 # limitations under the License.
 
 - name: Perform a Designate DB sync
-  command: "{{ designate_bin }}/designate-manage database sync"
+  ansible.builtin.command: "{{ designate_bin }}/designate-manage database sync"
   become: true
   become_user: "{{ designate_system_user_name }}"
   changed_when: false

tasks/designate_install.yml

@@ -14,7 +14,7 @@
 # limitations under the License.
 
 - name: Record the installation method
-  ini_file:
+  community.general.ini_file:
     dest: "/etc/ansible/facts.d/openstack_ansible.fact"
     section: "designate"
     option: "install_method"
@@ -22,12 +22,12 @@
     mode: "0644"
 
 - name: Refresh local facts to ensure the designate section is present
-  setup:
+  ansible.builtin.setup:
     filter: ansible_local
     gather_subset: "!all"
 
 - name: Install designate distro packages
-  package:
+  ansible.builtin.package:
     name: "{{ designate_package_list }}"
     state: "{{ designate_package_state }}"
     update_cache: "{{ (ansible_facts['pkg_mgr'] == 'apt') | ternary('yes', omit) }}"
@@ -38,7 +38,7 @@
   delay: 2
 
 - name: Install the python venv
-  include_role:
+  ansible.builtin.include_role:
     name: "python_venv_build"
   vars:
     venv_python_executable: "{{ designate_venv_python_executable }}"

tasks/designate_post_install.yml

@@ -28,7 +28,7 @@
   delay: 15
 
 - name: Store project id for managed resources
-  set_fact:
+  ansible.builtin.set_fact:
     designate_managed_resource_tenant_id: "{{ _get_managed_resource_project.projects[0].id }}"
 
 - name: Copy designate config
@@ -71,7 +71,7 @@
     - designate-policy-override
 
 - name: Remove legacy policy.yaml file
-  file:
+  ansible.builtin.file:
     path: "/etc/designate/policy.yaml"
     state: absent
   when:
@@ -80,7 +80,7 @@
     - designate-policy-override
 
 - name: Create Designate rndc key file
-  template:
+  ansible.builtin.template:
     src: rndc.key.j2
     dest: "{{ item.file }}"
     owner: "{{ item.owner | default('root') }}"
@@ -90,7 +90,7 @@
   when: designate_rndc_keys is defined
 
 - name: Copy rootwrap filters
-  copy:
+  ansible.builtin.copy:
     src: "{{ item }}"
     dest: "/etc/designate/rootwrap.d/"
     owner: "root"

tasks/designate_pre_install.yml

@@ -14,13 +14,13 @@
 # limitations under the License.
 
 - name: Create the system group
-  group:
+  ansible.builtin.group:
     name: "{{ designate_system_group_name }}"
     state: "present"
     system: "yes"
 
 - name: Create the designate system user
-  user:
+  ansible.builtin.user:
     name: "{{ designate_system_user_name }}"
     group: "{{ designate_system_group_name }}"
     comment: "{{ designate_system_comment }}"
@@ -30,7 +30,7 @@
     home: "{{ designate_system_user_home }}"
 
 - name: Create designate dir
-  file:
+  ansible.builtin.file:
     path: "{{ item.path }}"
     state: directory
     owner: "{{ item.owner | default(designate_system_user_name) }}"
@@ -46,7 +46,7 @@
     - { path: "/var/cache/designate", mode: "0700" }
 
 - name: Drop sudoers file
-  template:
+  ansible.builtin.template:
     src: "sudoers.j2"
     dest: "/etc/sudoers.d/{{ designate_system_user_name }}_sudoers"
     mode: "0440"

tasks/main.yml

@@ -14,7 +14,7 @@
 # limitations under the License.
 
 - name: Fail if service was deployed using a different installation method
-  fail:
+  ansible.builtin.fail:
     msg: "Switching installation methods for OpenStack services is not supported"
   when:
     - ansible_local is defined
@@ -24,7 +24,7 @@
     - ansible_local.openstack_ansible.designate.install_method != designate_install_method
 
 - name: Gather variables for each operating system
-  include_vars: "{{ lookup('first_found', params) }}"
+  ansible.builtin.include_vars: "{{ lookup('first_found', params) }}"
   vars:
     params:
       files:
@@ -39,12 +39,12 @@
     - always
 
 - name: Gather variables for installation method
-  include_vars: "{{ designate_install_method }}_install.yml"
+  ansible.builtin.include_vars: "{{ designate_install_method }}_install.yml"
   tags:
     - always
 
 - name: Including osa.db_setup role
-  include_role:
+  ansible.builtin.include_role:
     name: openstack.osa.db_setup
     apply:
       tags:
@@ -66,7 +66,7 @@
     - always
 
 - name: Including osa.mq_setup role
-  include_role:
+  ansible.builtin.include_role:
     name: openstack.osa.mq_setup
     apply:
       tags:
@@ -93,17 +93,17 @@
     - always
 
 - name: Importing designate_pre_install tasks
-  import_tasks: designate_pre_install.yml
+  ansible.builtin.import_tasks: designate_pre_install.yml
   tags:
     - designate-install
 
 - name: Importing designate_install tasks
-  import_tasks: designate_install.yml
+  ansible.builtin.import_tasks: designate_install.yml
   tags:
     - designate-install
 
 - name: Create and install SSL certificates
-  include_role:
+  ansible.builtin.include_role:
     name: pki
     tasks_from: main_certs.yml
     apply:
@@ -123,14 +123,14 @@
     - always
 
 - name: Importing designate_post_install tasks
-  import_tasks: designate_post_install.yml
+  ansible.builtin.import_tasks: designate_post_install.yml
   tags:
     - designate-install
     - designate-config
     - post-install
 
 - name: Including osa.service_setup tasks
-  include_role:
+  ansible.builtin.include_role:
     name: openstack.osa.service_setup
     apply:
       tags:
@@ -166,7 +166,7 @@
     - always
 
 - name: Run the systemd service role
-  import_role:
+  ansible.builtin.import_role:
     name: systemd_service
   vars:
     systemd_user_name: "{{ designate_system_user_name }}"
@@ -185,16 +185,15 @@
     - systemd-service
 
 - name: Flush handlers
-  meta: flush_handlers
-
+  ansible.builtin.meta: flush_handlers
 - name: Importing designate_db_sync tasks
-  import_tasks: designate_db_sync.yml
+  ansible.builtin.import_tasks: designate_db_sync.yml
   when: _designate_is_first_play_host
   tags:
     - designate-install
 
 - name: Place Designate pools.yaml file
-  copy:
+  ansible.builtin.copy:
     content: "{{ designate_pools_yaml | to_nice_yaml }}"
     dest: "/etc/designate/pools.yaml"
     mode: "0640"
@@ -209,4 +208,4 @@
     - designate-config
 
 - name: Flush handlers
-  meta: flush_handlers
+  ansible.builtin.meta: flush_handlers