From f9b918ea48bd2abe6f696c574b7ab3f99eff2cbd Mon Sep 17 00:00:00 2001 From: Craig Bryant Date: Tue, 24 Mar 2015 12:28:36 -0600 Subject: [PATCH] Only write value_meta column if it has a value This was recommended by the InfluxDB guys Change-Id: If9fefc8bb0aa8dab769197d14f715881831164eb --- .../monasca/persister/repository/InfluxV9MetricRepo.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/java/src/main/java/monasca/persister/repository/InfluxV9MetricRepo.java b/java/src/main/java/monasca/persister/repository/InfluxV9MetricRepo.java index f78d5515..00f33640 100644 --- a/java/src/main/java/monasca/persister/repository/InfluxV9MetricRepo.java +++ b/java/src/main/java/monasca/persister/repository/InfluxV9MetricRepo.java @@ -95,17 +95,15 @@ public class InfluxV9MetricRepo extends InfluxMetricRepo { Map valueMap = new HashMap<>(); valueMap.put("value", measurement.value); - String valueMetaJson = null; if (measurement.valueMeta != null && !measurement.valueMeta.isEmpty()) { try { - valueMetaJson = objectMapper.writeValueAsString(measurement.valueMeta); + final String valueMetaJson = objectMapper.writeValueAsString(measurement.valueMeta); logger.debug("Added value for value_meta of {}", valueMetaJson); + valueMap.put("value_meta", valueMetaJson); } catch (JsonProcessingException e) { - logger.error("Unable to serialize " + measurement.valueMeta, e); - valueMetaJson = null; + logger.error("Unable to serialize {}", measurement.valueMeta, e); } } - valueMap.put("value_meta", valueMetaJson); InfluxPoint influxPoint = new InfluxPoint(def.name, tagMap, dateString, valueMap); influxPointList.add(influxPoint);