openstack/monasca-persister
Code Issues Proposed changes

Only write value_meta column if it has a value

Browse Source 
This was recommended by the InfluxDB guys

Change-Id: If9fefc8bb0aa8dab769197d14f715881831164eb
This commit is contained in:
Craig Bryant 2015-03-24 12:28:36 -06:00
parent 3ba4356bf1
commit f9b918ea48
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
java/src/main/java/monasca/persister/repository/InfluxV9MetricRepo.java
View File

@ -95,17 +95,15 @@ public class InfluxV9MetricRepo extends InfluxMetricRepo {
Map<String, Object> valueMap = new HashMap<>();
valueMap.put("value", measurement.value);
String valueMetaJson = null;
if (measurement.valueMeta != null && !measurement.valueMeta.isEmpty()) {
try {
valueMetaJson = objectMapper.writeValueAsString(measurement.valueMeta);
final String valueMetaJson = objectMapper.writeValueAsString(measurement.valueMeta);
logger.debug("Added value for value_meta of {}", valueMetaJson);
valueMap.put("value_meta", valueMetaJson);
} catch (JsonProcessingException e) {
logger.error("Unable to serialize " + measurement.valueMeta, e);
valueMetaJson = null;
logger.error("Unable to serialize {}", measurement.valueMeta, e);
}
}
valueMap.put("value_meta", valueMetaJson);
InfluxPoint influxPoint = new InfluxPoint(def.name, tagMap, dateString, valueMap);
influxPointList.add(influxPoint);