From e6375f6ccca2398414d53c2583a7a54e18cf73bd Mon Sep 17 00:00:00 2001
From: Roland Hochmuth <roland.hochmuth@hp.com>
Date: Tue, 6 Oct 2015 16:22:06 -0600
Subject: [PATCH] Validate metricsString does not exceed max length

Change-Id: I3d4bf5f2ec8386681d06d26582d9d7267f50e208
---
 .../repository/vertica/VerticaAlarmRepo.java       | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/java/src/main/java/monasca/persister/repository/vertica/VerticaAlarmRepo.java b/java/src/main/java/monasca/persister/repository/vertica/VerticaAlarmRepo.java
index bed19657..96122650 100644
--- a/java/src/main/java/monasca/persister/repository/vertica/VerticaAlarmRepo.java
+++ b/java/src/main/java/monasca/persister/repository/vertica/VerticaAlarmRepo.java
@@ -50,6 +50,8 @@ public class VerticaAlarmRepo extends VerticaRepo implements Repo<AlarmStateTran
   private static final String SQL_INSERT_INTO_ALARM_HISTORY =
       "insert into MonAlarms.StateHistory (tenant_id, alarm_id, metrics, old_state, new_state, sub_alarms, reason, reason_data, time_stamp) "
       + "values (:tenant_id, :alarm_id, :metrics, :old_state, :new_state, :sub_alarms, :reason, :reason_data, :time_stamp)";
+  private static final int MAX_BYTES_PER_CHAR = 4;
+  private static final int MAX_LENGTH_VARCHAR = 65000;
 
   private PreparedBatch batch;
   private final Timer commitTimer;
@@ -96,8 +98,20 @@ public class VerticaAlarmRepo extends VerticaRepo implements Repo<AlarmStateTran
 
     String metricsString = getSerializedString(message.metrics, id);
 
+    // Validate metricsString does not exceed a sufficient maximum upper bound
+    if (metricsString.length()*MAX_BYTES_PER_CHAR >= MAX_LENGTH_VARCHAR) {
+      metricsString = "[]";
+      logger.warn("length of metricsString for alarm ID {} exceeds max length of {}", message.alarmId, MAX_LENGTH_VARCHAR);
+    }
+
     String subAlarmsString = getSerializedString(message.subAlarms, id);
 
+    // Validate subAlarmsString does not exceed a sufficient maximum upper bound
+    if (subAlarmsString.length()*MAX_BYTES_PER_CHAR >= MAX_LENGTH_VARCHAR) {
+      subAlarmsString = "[]";
+      logger.warn("length of subAlarmsString for alarm ID {} exceeds max length of {}", message.alarmId, MAX_LENGTH_VARCHAR);
+    }
+
     String timeStamp = simpleDateFormat.format(new Date(message.timestamp));
 
     batch.add()