Using "python setup.py check -r -s" method of checking the package has
been deprecated with the new recommendation to build the sdist and
wheel, then running "twine check" against the output.
Luckily, there is already a job that covers this that only runs when the
README, setup.py, or setup.cfg files change, making running this in the
pep8 job redundant. This covered by the test-release-openstack-python3
that is defined in the publish-to-pypi-python3 template.
More details can be found in this mailing list post:
http://lists.openstack.org/pipermail/openstack-dev/2018-October/136136.html
Change-Id: I7a3555dd0f0c4bcd1969ca7d3669369d7517a6be
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Depends-On: https://review.openstack.org/615557
Quotes around {posargs} cause the entire string to be combined into one
arg that gets passed to stestr. This prevents passing multiple args
(e.g. '--concurrency=16 some-regex')
Change-Id: I068ac92a340a5a31af53f77b69a702c5c138b4c8
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: Idd29b6d5460510ec02ec10853a0809185e5823cd
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Creating the release would fail if the syntax of README.rst is not
correct. Let's check it in the pep8 environment.
Story: 2002163
Task: 23044
Change-Id: I2856622af08cec7c801959ca85f4c77252263db5
According to Openstack summit session [1] stestr is
maintained project to which all Openstack projects
should migrate.
Let's switch it then.
[1] https://etherpad.openstack.org/p/YVR-python-pti
Change-Id: Iebd6f34335e4ef0dd3629e970661d8c9ef08754a
Signed-off-by: Charles Short <zulcss@gmail.com>
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: Ia156a087ff8f04307f255e61f3f2e9ffdae42861
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* set the maximum line length to 100
* removed unnecessary ignores
* updated codes for pep8
* added apache 2.0 license for missed files
Change-Id: If9398a8fdd094e50d6a07cb73f7389558dbe0a0d
Signed-off-by: Amir Mofakhar <amofakhar@op5.com>
Create a tox environment for running the unit tests against the lower
bounds of the dependencies.
Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.
Add openstack-tox-lower-constraints job to the zuul configuration.
See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.
Change-Id: I0ef8ed50f55fa905b6090805a3088fc5ab56906c
Depends-On: https://review.openstack.org/555034
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
'pip install -U' ugrades specified packages, this is not necessary
since we use constraints, remove the parameter '-U' from the line.
With tools/tox_install.sh - which a previous change of mine removed -
the -U was not harmful, but with the current set up, it might cause
upgrades, so remove it.
Change-Id: Ife6a6d88f636057f87d47fe79af8bfcff897ccc1
We do not need tox_install.sh, pip can handle constraints itself
and install the project correctly. Thus update tox.ini and remove
the now obsolete tools/tox_install.sh file.
This follows https://review.openstack.org/#/c/508061 to remove
tools/tox_install.sh.
Change-Id: Ib55145fd3f0ed0d8d56379c718e91ff55aa4aa27
Following commits does several things:
* migrates CI of monasca-common to ostestr
* enables PY35 compatybility
Also:
* marked one tests as excluded under PY35 because changing
it would require affecting embedded kafka library which
will be eventually removed in future
Change-Id: I432a466e2620bc8d305ef2630307b636461c8e81
Add bandit job as part of pep8 in tox.ini
Had to ignore assert check since those are use for performance in the
validation code. Also, skipped bandit checks of monasca_common/kafka_lib
since that is just a clone of kafka-python and will be deleted in the
future
Change-Id: Ie2e726a8e45ef463c4e863792eed663ee472ed07
To let other OpenStack projects move forward with new versions of kafka-python
we're forking kafka-python and embedding it in monasca-common. This allows us
to migrate to the new async interfaces provided by more recent kafka clients
over time and not block other projects.
Requiring pykafka to allow us to have ~4x more throughput once we write to
their async interfaces.
Change-Id: Ifb6ab67ce1335a5ec4ed7dd8b0027dc9d46a6dda
Depends-On: I26f9c588f2818059ab6ba24f9fad8e213798a39c
There is no this directory openstack/common which was used
to keep codes from oslo-incubator, we have retired oslo-incubator.
Removing openstack/commonfrom all OpenStack code in favor of the
Oslo libraries is a project wide goal for the Ocata release. So
don't use this directory any more. We should drop it for improving
searching efficiency.
Change-Id: I2e1a7ac2f9a8734ec60cf01ef04251fac3882452
Cleaned up test-requirements.txt in order to use the latest hacking
package.
Removed the ignored pep8 checks and made the code pass all of them.
Also removed the OpenStack Foundation copyright notice that was put
there accidentally before.
Change-Id: I3d287eb71fc2bf0e4d52856c11cbc8a347cac2ed
This review is to prepare for adding monasca-common into openstack
global-requirements. After this project gets into global requirements,
it will be in upper-constraints.txt. If we make changes on this
specific project, we need to replace it in the upper-constraints with
source based specifier before applying it to pip install.
Change-Id: I67a3e3fcb833e273900c490643197988efd5eb3b
Add tests for kafka producer and consumer modules. The test coverage
of monasca_common was was 9%. This is improved in this commit.
Show test coverage when running tox. Change the nosetests command to
show test coverage for the whole module.
Change-Id: I771a539aee5fa92c065ee16b5bb94c9ae7e7a09b
Bring over the cleaning line from run_tests.sh for the pyc files to
all the tox runs.
This should eliminate the need to clean -x -i to kill pyc files in
your local directory to get tests to pass.
Change-Id: I0f59c977411d20751a26cac39504c51896b2eab8
Closes-Bug: #1368661
This is the start of a python monasca-common package.
Initially it has a common python logging config,
common oslo opts, and mysql common code.
Change-Id: I15c32b72fc42a8c5ce9eeedf20ca3a11907bf29f
