openstack/ceilometermiddleware
Code Issues Proposed changes

Convert nonblocking_notify value from string to boolean

Browse Source 
Otherwise just setting it to "False" which is a string and therefore, is
True, enables it!

Change-Id: Iaa5a25e9c7c1d33d13a244d5afe440cd5f1d9883
This commit is contained in:
Julien Danjou 2016-11-07 18:36:18 +01:00 committed by Pradeep Kilambi
parent 163b2060fa
commit 87bd49b62e
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ceilometermiddleware/swift.py
View File

@ -51,6 +51,7 @@ import logging
from oslo_config import cfg from oslo_config import cfg
import oslo_messaging import oslo_messaging
from oslo_utils import strutils
from pycadf import event as cadf_event from pycadf import event as cadf_event
from pycadf.helper import api from pycadf.helper import api
from pycadf import measurement as cadf_measurement from pycadf import measurement as cadf_measurement
@ -142,7 +143,8 @@ class Swift(object):
# For backward compatibility we default to False and therefore wait for # For backward compatibility we default to False and therefore wait for
# sending to complete. This causes swift proxy to hang if the # sending to complete. This causes swift proxy to hang if the
# destination is unavailable. # destination is unavailable.
self.nonblocking_notify = conf.get('nonblocking_notify', False) self.nonblocking_notify = strutils.bool_from_string(
conf.get('nonblocking_notify', False))
# Initialize the sending queue and thread, but only once # Initialize the sending queue and thread, but only once
if self.nonblocking_notify and Swift.event_queue is None: if self.nonblocking_notify and Swift.event_queue is None:

1
requirements.txt
View File

@ -4,6 +4,7 @@
oslo.config>=3.9.0 # Apache-2.0 oslo.config>=3.9.0 # Apache-2.0
oslo.messaging>=5.2.0 # Apache-2.0 oslo.messaging>=5.2.0 # Apache-2.0
oslo.utils
pbr>=1.6 # Apache-2.0 pbr>=1.6 # Apache-2.0
pycadf!=2.0.0,>=1.1.0 # Apache-2.0 pycadf!=2.0.0,>=1.1.0 # Apache-2.0
six>=1.9.0 # MIT six>=1.9.0 # MIT