From b1841dc4b90d9127884379d4fe1cccf99c7a579c Mon Sep 17 00:00:00 2001 From: Pierre Riteau Date: Wed, 20 Jan 2021 16:29:18 +0100 Subject: [PATCH] Fix use of legacy Alembic API The `name` keyword argument for Operations.alter_column() has been deprecated since version 0.8. It was finally removed in Alembic 1.5.0, causing the following error during installation of Blazar: TypeError: alter_column() got multiple values for keyword argument 'name' Change-Id: I05541da4d87575f65d8e78f0fc54bd415328b9f2 Closes-Bug: #1912502 --- .../versions/2bcfe76b0474_change_tenant_to_project.py | 4 ++-- .../notes/alembic-fix-alter-column-42a87657992d1e78.yaml | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 releasenotes/notes/alembic-fix-alter-column-42a87657992d1e78.yaml diff --git a/blazar/db/migration/alembic_migrations/versions/2bcfe76b0474_change_tenant_to_project.py b/blazar/db/migration/alembic_migrations/versions/2bcfe76b0474_change_tenant_to_project.py index 4d6e1f31..1fa37ddd 100644 --- a/blazar/db/migration/alembic_migrations/versions/2bcfe76b0474_change_tenant_to_project.py +++ b/blazar/db/migration/alembic_migrations/versions/2bcfe76b0474_change_tenant_to_project.py @@ -40,7 +40,7 @@ def upgrade(): op.execute('ALTER TABLE tmp_leases RENAME TO leases') return - op.alter_column('leases', 'tenant_id', name='project_id', + op.alter_column('leases', 'tenant_id', new_column_name='project_id', existing_type=sa.String(length=255)) @@ -55,5 +55,5 @@ def downgrade(): op.execute('ALTER TABLE tmp_leases RENAME TO leases') return - op.alter_column('leases', 'project_id', name='tenant_id', + op.alter_column('leases', 'project_id', new_column_name='tenant_id', existing_type=sa.String(length=255)) diff --git a/releasenotes/notes/alembic-fix-alter-column-42a87657992d1e78.yaml b/releasenotes/notes/alembic-fix-alter-column-42a87657992d1e78.yaml new file mode 100644 index 00000000..ecc68ea8 --- /dev/null +++ b/releasenotes/notes/alembic-fix-alter-column-42a87657992d1e78.yaml @@ -0,0 +1,5 @@ +--- +fixes: + - | + Fixes database migrations with Alembic 1.5.0 or greater. For more details, + see `bug 1912502 `_.